ImageName should throw exception when digest length is too small #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devashishbasu
requested review from
manusa,
rohanKanojia and
sunix
as code owners
Eclipse JKube CI ReportStarted new GH workflow run for #2557 (2024-01-24T05:15:01Z) ⚙️ JKube E2E Tests (7635757079)
|
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2557 +/- ##
=============================================
+ Coverage 59.36% 69.82% +10.46%
- Complexity 4586 4901 +315
=============================================
Files 500 474 -26
Lines 21211 19173 -2038
Branches 2830 2480 -350
=============================================
+ Hits 12591 13387 +796
+ Misses 7370 4570 -2800
+ Partials 1250 1216 -34 ☔ View full report in Codecov by Sentry. |
|
Hii @rohanKanojia when i am updating the digest regex with mentioned in the issue [A-Za-z][A-Za-z0-9](?:[-_+.][A-Za-z][A-Za-z0-9])*[:][[:xdigit:]]{32,} some tests in ImageNameFullNameParseTest is failing but when i updated digest regex with "^(?:sha256:)?[a-fA-F0-9]{64}$" all test cases passed in ImageNameFullNameParseTest....can you please review it? |
|
This issue aimed to align our regex to match what's in docker source. We need to investigate why those tests have started failing. Are those tests having valid SHA 256 digests in expectations? Or the digest regex that I mentioned in the issue is not the correct one? |
Hi @rohanKanojia i have updated the digest's regex to match with whats in docker distribution .....but some test cases are failing...this invalid digest repo@sha256:ffffffffffffffffffffffffffffffffff which you mentioned in the issue was passing previously is failing now and some more test cases are failing for example... 19@sha256:b7d8650e04b282b9d7b94daedf38321512f9910bce896cd40ffa15b1b92bab17' is invalid:
'127.0.0.1:5000/hello-world@sha256:b94d27b9934d3e08a52e52d7da7dabfac484efe37a5380ee9088f7ace2efcde9' is invalid:
if the digest's regex is correct than i think these failing test cases do not have valid SHA 256 digests |
rohanKanojia
changed the title
|
@Devashishbasu : Do the tests pass if you replace existing digests with some valid doest? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2543