feat (jkube-kit/build/service/buildpacks) : Add BuildPackCliController (#2453) #2496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #2496 (2024-01-25T13:06:07Z) ⚙️ JKube E2E Tests (7654819757)
|
18 tasks
rohanKanojia
force-pushed
the
pr/issue2453
branch
from
b37abff to
6ca424e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2496 +/- ##
=============================================
+ Coverage 59.36% 70.32% +10.96%
- Complexity 4586 4962 +376
=============================================
Files 500 480 -20
Lines 21211 19308 -1903
Branches 2830 2494 -336
=============================================
+ Hits 12591 13579 +988
+ Misses 7370 4501 -2869
+ Partials 1250 1228 -22 ☔ View full report in Codecov by Sentry. |
rohanKanojia
force-pushed
the
pr/issue2453
branch
from
6ca424e to
5efd9f5
Compare
|
Sonar coverage is reduced due to BuildPackBuildOptions configuration class using Lombok annotations. |
manusa
reviewed
Jan 18, 2024
| BuildPackCommand buildPackCommand = new BuildPackCommand(kitLogger, pack, | ||
| createBuildCommandArguments(buildOptions), | ||
| l -> kitLogger.info("[[s]]%s", l)); | ||
| executePackCommand(buildPackCommand, e -> { |
There was a problem hiding this comment.
Is there any reason we're doing this in such a weird way instead of using a regular try-catch block?
There was a problem hiding this comment.
Umm, as far as I remember it was done to avoid duplicating try catch block
There was a problem hiding this comment.
I have reverted to having try catch blocks in both methods
manusa
reviewed
Jan 18, 2024
...s/src/main/java/org/eclipse/jkube/kit/service/buildpacks/controller/BuildPackController.java
Show resolved
Hide resolved
rohanKanojia
force-pushed
the
pr/issue2453
branch
from
5efd9f5 to
55756ea
Compare
manusa
reviewed
Jan 19, 2024
Comment on lines
68
to
69
| buildArgs.addAll(extractStringArg("--builder", buildOptions.getBuilderImage())); | ||
| buildArgs.addAll(extractStringArg("--creation-time", buildOptions.getCreationTime())); |
There was a problem hiding this comment.
Sorry for nitpicking again, but I can't see either the increase in cognitive complexity for extractStringAsArgeither.
What's the case where flagValue will be blank?
If there's no such case, Arrays.asList proves to be more readable.
If the case is that any of those flag values might be optionally present, I'd try to be more explicit about this toArgsIfPresent or something like that.
manusa
reviewed
Jan 19, 2024
rohanKanojia
force-pushed
the
pr/issue2453
branch
from
55756ea to
716ffb8
Compare
manusa
approved these changes
Jan 25, 2024
|
Needs rebase so that the java-8 check passes |
eclipse-jkube#2453) Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/issue2453
branch
from
716ffb8 to
def03ae
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2453
Type of change
test, version modification, documentation, etc.)
Checklist