-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BuildConfigurationTest uses deprecated ObjectMapper.configure method #2525
Comments
I'll be working on this |
can i work on this? |
@anglerfishlyy : Are you still working on #2879 ? |
No sir. |
Hi @anglerfishlyy, what's the status on this issue, have you progressed? |
actually , the lines are already changed to required one in the code. Is it still an issue that needs to be resolved? |
@anglerfishlyy : Yes, you're right. Code still needs to be updated. |
You're right, this was fixed in #2549 |
#2528 wasn't fixed, so maybe you can attempt to fix that one. @anglerfishlyy, if you want, please comment in #2528 so that we can assign it to you. |
Description
The class BuildConfigurationTest uses a deprecated method.
The following lines should be changed to (updating imports if necessary):
https://github.com/eclipse/jkube/blob/275dc11e9bd0a268aac94f112ac2c443960d957b/jkube-kit/config/image/src/test/java/org/eclipse/jkube/kit/config/image/build/BuildConfigurationTest.java#L237-L238
Before you start 🔴
👇 👇 👇 👇 👇 👇 👇 👇 👇 👇👇👇👇👇👇👇
Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.
How to manually test my changes
Kubernetes
If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.
OpenShift
If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.
Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the
?
icon and from the context menu selectCommand line tools
, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)The text was updated successfully, but these errors were encountered: