SecretEnricher getSecretsFromXmlConfig should return Collections.empt…

…yList() instead of null
eclipse-jkube · Jan 13, 2024 · f90f423 · f90f423
1 parent 82999a0
commit f90f423
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/...kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/SecretEnricher.java b/...kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/SecretEnricher.java
@@ -28,9 +28,7 @@
 import org.eclipse.jkube.kit.enricher.api.util.SecretConstants;
 import org.apache.commons.lang3.StringUtils;
 
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
+import java.util.*;
 
 public abstract class SecretEnricher extends BaseEnricher {
 
@@ -129,10 +127,8 @@ private void addSecretsFromXmlConfiguration(KubernetesListBuilder builder) {
 
     private List<SecretConfig> getSecretsFromXmlConfig() {
         ResourceConfig resourceConfig = getConfiguration().getResource();
-        if(resourceConfig != null && resourceConfig.getSecrets() != null) {
-            return resourceConfig.getSecrets();
-        }
-        return null;
+        return Optional.ofNullable(resourceConfig.getSecrets()).orElse(Collections.emptyList());
+
     }
 
     private String getDockerIdFromAnnotation(Map<String, String> annotation) {