updating changes

eclipse-jkube · Jan 18, 2024 · ad8f7a5 · ad8f7a5
1 parent 325723f
commit ad8f7a5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/jkube-kit/config/image/src/main/java/org/eclipse/jkube/kit/config/image/ImageName.java b/jkube-kit/config/image/src/main/java/org/eclipse/jkube/kit/config/image/ImageName.java
@@ -292,13 +292,11 @@ private void doValidate() {
                         checks[i], value, checkPattern.pattern()));
             }
         }
-
-        // Additional validation for repository length
-        if (repository != null) {
-            int repositoryLength = repository.length();
-            if (repositoryLength > 255) {
-                errors.add(String.format("Repository name '%s' has a length of %d characters, which exceeds the maximum of 255 characters.", repository, repositoryLength));
-            }
+        // Additional validation for total image name length
+        String fullNameWithoutTagAndDigest = getNameWithoutTag(null);
+        int fullNameLength = fullNameWithoutTagAndDigest.length();
+        if (fullNameLength > 255) {
+            errors.add(String.format("Total image name '%s' has a length of %d characters, which exceeds the maximum of 255 characters.", fullNameWithoutTagAndDigest, fullNameLength));
         }
 
         if (!errors.isEmpty()) {

diff --git a/.../src/test/java/org/eclipse/jkube/kit/config/image/ImageNameDistributionReferenceTest.java b/.../src/test/java/org/eclipse/jkube/kit/config/image/ImageNameDistributionReferenceTest.java
@@ -95,7 +95,7 @@ void validNames(String name) {
       ":justtag",
       "@sha256:ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff",
       "a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a/a:tag", // https://github.com/eclipse/jkube/issues/2542
-      //"repo@sha256:ffffffffffffffffffffffffffffffffff", // https://github.com/eclipse/jkube/issues/2543
+      "repo@sha256:ffffffffffffffffffffffffffffffffff", // https://github.com/eclipse/jkube/issues/2543
       "validname@invaliddigest:ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff",
       "Uppercase:tag",
       "test:5000/Uppercase/lowercase:tag",