refactor: Service Type LoadBalancer is not a requirement for Ingress …

…generation
eclipse-jkube · Jan 27, 2021 · 73c79d8 · 73c79d8
1 parent efe3e90
commit 73c79d8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/...it/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/IngressEnricher.java b/...it/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/IngressEnricher.java
@@ -270,11 +270,7 @@ static boolean shouldCreateExternalURLForService(ServiceBuilder service, KitLogg
             List<ServicePort> ports = spec.getPorts();
             log.debug("Service " + serviceName + " has ports: " + ports);
             if (ports.size() == 1) {
-                String type = spec.getType();
-                if (Objects.equals(type, "LoadBalancer")) {
-                    return true;
-                }
-                log.info("Not generating Ingress for service " + serviceName + " type is not LoadBalancer: " + type);
+                return true;
             } else {
                 log.info("Not generating Ingress for service " + serviceName + " as only single port services are supported. Has ports: " + ports);
             }

diff --git a/...nricher/generic/src/test/java/org/eclipse/jkube/enricher/generic/IngressEnricherTest.java b/...nricher/generic/src/test/java/org/eclipse/jkube/enricher/generic/IngressEnricherTest.java
@@ -301,7 +301,7 @@ public void testShouldCreateExternalURLForServiceWithClusterIP() {
       assertThat(IngressEnricher.shouldCreateExternalURLForService(initTestService().editSpec()
           .withType("ClusterIP")
           .endSpec(), logger))
-              .isFalse();
+              .isTrue();
     }
 
     @Test