From 4df383a5b570ebabe51cc89372ed441faf1bac9e Mon Sep 17 00:00:00 2001 From: Rohan Kumar Date: Wed, 24 Jan 2024 17:13:33 +0530 Subject: [PATCH] test (jkube-kit/remote-dev) : Fix intermittent failures of RemoteDevelopmentServiceTest Signed-off-by: Rohan Kumar --- .../jkube/kit/remotedev/RemoteDevelopmentServiceTest.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/jkube-kit/remote-dev/src/test/java/org/eclipse/jkube/kit/remotedev/RemoteDevelopmentServiceTest.java b/jkube-kit/remote-dev/src/test/java/org/eclipse/jkube/kit/remotedev/RemoteDevelopmentServiceTest.java index 2fc692e7ea..634e07005f 100644 --- a/jkube-kit/remote-dev/src/test/java/org/eclipse/jkube/kit/remotedev/RemoteDevelopmentServiceTest.java +++ b/jkube-kit/remote-dev/src/test/java/org/eclipse/jkube/kit/remotedev/RemoteDevelopmentServiceTest.java @@ -23,9 +23,12 @@ import org.junit.jupiter.api.DisplayName; import org.junit.jupiter.api.Test; +import java.net.InetAddress; import java.net.ServerSocket; +import java.net.Socket; import static org.assertj.core.api.Assertions.assertThatThrownBy; +import static org.assertj.core.api.AssertionsForClassTypes.assertThat; import static org.mockito.Mockito.spy; import static org.mockito.Mockito.timeout; import static org.mockito.Mockito.times; @@ -118,8 +121,11 @@ void startFailsIfLocalPortInUse() { remoteDevelopmentService = new RemoteDevelopmentService( logger, kubernetesClient, RemoteDevelopmentConfig.builder().remoteService(remoteService).build()); assertThatThrownBy(() -> { - try (ServerSocket localPortInUse = new ServerSocket(localPort)) { + try (ServerSocket localPortInUse = new ServerSocket(localPort, 50, InetAddress.getByName("localhost"))) { // When + try (Socket socket = new Socket("localhost", localPortInUse.getLocalPort())) { + assertThat(socket.isBound()).isTrue(); + } remoteDevelopmentService.start(); } })