Introduce parallel rollout processing #2248
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denislav Prinov <denislav.prinov@bosch.com>
|
Can one of the admins verify this patch? |
vasilchev
reviewed
Jan 28, 2025
...epository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/rollout/RolloutScheduler.java
Outdated
Show resolved
Hide resolved
avgustinmm
requested changes
Jan 29, 2025
...jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/RepositoryApplicationConfiguration.java
Outdated
Show resolved
Hide resolved
...epository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/rollout/RolloutScheduler.java
Outdated
Show resolved
Hide resolved
...epository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/rollout/RolloutScheduler.java
Outdated
Show resolved
Hide resolved
… Changing to previous default behaviour when the thread pool size is <=1 Signed-off-by: Denislav Prinov <denislav.prinov@bosch.com>
avgustinmm
reviewed
Jan 29, 2025
...jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/RepositoryApplicationConfiguration.java
Outdated
Show resolved
Hide resolved
...epository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/rollout/RolloutScheduler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Denislav Prinov <denislav.prinov@bosch.com>
|
avgustinmm
reviewed
Feb 3, 2025
| final RolloutHandler rolloutHandler, final SystemSecurityContext systemSecurityContext) { | ||
| return new RolloutScheduler(rolloutHandler, systemManagement, systemSecurityContext); | ||
| final RolloutHandler rolloutHandler, final SystemSecurityContext systemSecurityContext, @Value("${hawkbit.rollout.executor.thread-pool.size:1}") int threadPoolSize) { | ||
| return new RolloutScheduler(rolloutHandler, systemManagement, systemSecurityContext, threadPoolSize); |
| import java.util.concurrent.ThreadPoolExecutor; | ||
|
|
||
| public class BlockWhenFullPolicy implements RejectedExecutionHandler { | ||
| @Override |
There was a problem hiding this comment.
4 spaces indents, please use hawkbit formatter
| this.systemManagement = systemManagement; | ||
| this.rolloutHandler = rolloutHandler; | ||
| this.systemSecurityContext = systemSecurityContext; | ||
| this.rolloutTaskExecutor = threadPoolTaskExecutor(threadPoolSize); |
| return null; | ||
| }); | ||
| } | ||
|
|
||
| private void handleAll(String tenant) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current default behaviour is preserved if the thread pool size is <=1 (default thread pool size value is 1). If parallel execution is needed, the hawkbit.rollout.executor.thread-pool.size property should be set to a value > 1