diff --git a/hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/management/JpaDistributionSetManagement.java b/hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/management/JpaDistributionSetManagement.java index a27ccd52e6..aec40d8042 100644 --- a/hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/management/JpaDistributionSetManagement.java +++ b/hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/management/JpaDistributionSetManagement.java @@ -153,7 +153,6 @@ public JpaDistributionSetManagement( @Transactional @Retryable(retryFor = { ConcurrencyFailureException.class }, maxAttempts = Constants.TX_RT_MAX, backoff = @Backoff(delay = Constants.TX_RT_DELAY)) - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_CREATE_REPOSITORY) public List create(final Collection creates) { final List toCreate = creates.stream().map(JpaDistributionSetCreate.class::cast) .map(this::setDefaultTypeIfMissing).map(JpaDistributionSetCreate::build).toList(); @@ -209,7 +208,6 @@ public DistributionSet update(final DistributionSetUpdate u) { } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public long count() { return distributionSetRepository.count(DistributionSetSpecification.isNotDeleted()); } @@ -218,7 +216,6 @@ public long count() { @Transactional @Retryable(retryFor = { ConcurrencyFailureException.class }, maxAttempts = Constants.TX_RT_MAX, backoff = @Backoff(delay = Constants.TX_RT_DELAY)) - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_DELETE_REPOSITORY) public void delete(final long id) { delete(List.of(id)); } @@ -227,7 +224,6 @@ public void delete(final long id) { @Transactional @Retryable(retryFor = { ConcurrencyFailureException.class }, maxAttempts = Constants.TX_RT_MAX, backoff = @Backoff(delay = Constants.TX_RT_DELAY)) - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_DELETE_REPOSITORY) public void delete(final Collection distributionSetIDs) { getDistributionSets(distributionSetIDs); // throws EntityNotFoundException if any of these do not exists final List setsFound = distributionSetRepository.findAll( @@ -268,32 +264,27 @@ public void delete(final Collection distributionSetIDs) { } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public List get(final Collection ids) { return Collections.unmodifiableList(getDistributionSets(ids)); } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public boolean exists(final long id) { return distributionSetRepository.existsById(id); } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public Optional get(final long id) { return distributionSetRepository.findById(id).map(DistributionSet.class::cast); } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public Slice findAll(final Pageable pageable) { return JpaManagementHelper.findAllWithoutCountBySpec(distributionSetRepository, pageable, List.of( DistributionSetSpecification.isNotDeleted())); } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public Page findByRsql(final Pageable pageable, final String rsqlParam) { return JpaManagementHelper.findAllWithCountBySpec(distributionSetRepository, pageable, List.of( RSQLUtility.buildRsqlSpecification(rsqlParam, DistributionSetFields.class, virtualPropertyReplacer, diff --git a/hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/management/JpaDistributionSetTagManagement.java b/hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/management/JpaDistributionSetTagManagement.java index 3f9904f6e2..e4db51f91c 100644 --- a/hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/management/JpaDistributionSetTagManagement.java +++ b/hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/management/JpaDistributionSetTagManagement.java @@ -74,7 +74,6 @@ public JpaDistributionSetTagManagement( @Transactional @Retryable(retryFor = { ConcurrencyFailureException.class }, maxAttempts = Constants.TX_RT_MAX, backoff = @Backoff(delay = Constants.TX_RT_DELAY)) - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_CREATE_REPOSITORY) public List create(final Collection dst) { final List toCreate = dst.stream().map(JpaTagCreate.class::cast) .map(JpaTagCreate::buildDistributionSetTag).toList(); @@ -111,7 +110,6 @@ public DistributionSetTag update(final TagUpdate u) { } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public long count() { return distributionSetTagRepository.count(); } @@ -120,7 +118,6 @@ public long count() { @Transactional @Retryable(retryFor = { ConcurrencyFailureException.class }, maxAttempts = Constants.TX_RT_MAX, backoff = @Backoff(delay = Constants.TX_RT_DELAY)) - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_DELETE_REPOSITORY) public void delete(final long id) { distributionSetTagRepository.deleteById(id); } @@ -129,7 +126,6 @@ public void delete(final long id) { @Transactional @Retryable(retryFor = { ConcurrencyFailureException.class }, maxAttempts = Constants.TX_RT_MAX, backoff = @Backoff(delay = Constants.TX_RT_DELAY)) - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_DELETE_REPOSITORY) public void delete(final Collection ids) { final List setsFound = distributionSetTagRepository.findAllById(ids); @@ -142,31 +138,26 @@ public void delete(final Collection ids) { } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public List get(final Collection ids) { return Collections.unmodifiableList(distributionSetTagRepository.findAllById(ids)); } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public boolean exists(final long id) { return distributionSetTagRepository.existsById(id); } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public Optional get(final long id) { return distributionSetTagRepository.findById(id).map(DistributionSetTag.class::cast); } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public Slice findAll(final Pageable pageable) { return JpaManagementHelper.findAllWithoutCountBySpec(distributionSetTagRepository, pageable, null); } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public Page findByRsql(final Pageable pageable, final String rsqlParam) { final Specification spec = RSQLUtility.buildRsqlSpecification(rsqlParam, DistributionSetTagFields.class, virtualPropertyReplacer, database); diff --git a/hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/management/JpaDistributionSetTypeManagement.java b/hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/management/JpaDistributionSetTypeManagement.java index c0843df288..9af80d4837 100644 --- a/hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/management/JpaDistributionSetTypeManagement.java +++ b/hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/management/JpaDistributionSetTypeManagement.java @@ -129,7 +129,6 @@ public DistributionSetType unassignSoftwareModuleType(final long id, final long @Transactional @Retryable(retryFor = { ConcurrencyFailureException.class }, maxAttempts = Constants.TX_RT_MAX, backoff = @Backoff(delay = Constants.TX_RT_DELAY)) - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_CREATE_REPOSITORY) public List create(final Collection types) { final List typesToCreate = types.stream() .map(JpaDistributionSetTypeCreate.class::cast) @@ -186,7 +185,6 @@ public DistributionSetType update(final DistributionSetTypeUpdate u) { } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public long count() { return distributionSetTypeRepository.count(DistributionSetTypeSpecification.isNotDeleted()); } @@ -195,7 +193,6 @@ public long count() { @Transactional @Retryable(retryFor = { ConcurrencyFailureException.class }, maxAttempts = Constants.TX_RT_MAX, backoff = @Backoff(delay = Constants.TX_RT_DELAY)) - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_DELETE_REPOSITORY) public void delete(final long id) { final JpaDistributionSetType toDelete = distributionSetTypeRepository.findById(id) .orElseThrow(() -> new EntityNotFoundException(DistributionSetType.class, id)); @@ -214,38 +211,32 @@ public void delete(final long id) { @Transactional @Retryable(retryFor = { ConcurrencyFailureException.class }, maxAttempts = Constants.TX_RT_MAX, backoff = @Backoff(delay = Constants.TX_RT_DELAY)) - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_DELETE_REPOSITORY) public void delete(final Collection ids) { distributionSetTypeRepository.deleteAllById(ids); } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public List get(final Collection ids) { return Collections.unmodifiableList(distributionSetTypeRepository.findAllById(ids)); } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public boolean exists(final long id) { return distributionSetTypeRepository.existsById(id); } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public Optional get(final long id) { return distributionSetTypeRepository.findById(id).map(DistributionSetType.class::cast); } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public Slice findAll(final Pageable pageable) { return JpaManagementHelper.findAllWithoutCountBySpec(distributionSetTypeRepository, pageable, List.of( DistributionSetTypeSpecification.isNotDeleted())); } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public Page findByRsql(final Pageable pageable, final String rsqlParam) { return JpaManagementHelper.findAllWithCountBySpec(distributionSetTypeRepository, pageable, List.of( RSQLUtility.buildRsqlSpecification(rsqlParam, DistributionSetTypeFields.class, virtualPropertyReplacer, database), diff --git a/hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/management/JpaSoftwareModuleManagement.java b/hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/management/JpaSoftwareModuleManagement.java index 73b7a65169..e41ffc2acf 100644 --- a/hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/management/JpaSoftwareModuleManagement.java +++ b/hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/management/JpaSoftwareModuleManagement.java @@ -120,7 +120,6 @@ public JpaSoftwareModuleManagement(final EntityManager entityManager, @Transactional @Retryable(retryFor = { ConcurrencyFailureException.class }, maxAttempts = Constants.TX_RT_MAX, backoff = @Backoff(delay = Constants.TX_RT_DELAY)) - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_CREATE_REPOSITORY) public List create(final Collection swModules) { final List modulesToCreate = swModules.stream().map(JpaSoftwareModuleCreate.class::cast) .map(JpaSoftwareModuleCreate::build).toList(); @@ -180,7 +179,6 @@ public SoftwareModule update(final SoftwareModuleUpdate u) { } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public long count() { return softwareModuleRepository.count(SoftwareModuleSpecification.isNotDeleted()); } @@ -189,7 +187,6 @@ public long count() { @Transactional @Retryable(retryFor = { ConcurrencyFailureException.class }, maxAttempts = Constants.TX_RT_MAX, backoff = @Backoff(delay = Constants.TX_RT_DELAY)) - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_DELETE_REPOSITORY) public void delete(final long id) { delete(List.of(id)); } @@ -198,7 +195,6 @@ public void delete(final long id) { @Transactional @Retryable(retryFor = { ConcurrencyFailureException.class }, maxAttempts = Constants.TX_RT_MAX, backoff = @Backoff(delay = Constants.TX_RT_DELAY)) - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_DELETE_REPOSITORY) public void delete(final Collection ids) { final List swModulesToDelete = softwareModuleRepository.findAllById(ids); if (swModulesToDelete.size() < ids.size()) { @@ -243,25 +239,21 @@ public void delete(final Collection ids) { } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public List get(final Collection ids) { return Collections.unmodifiableList(softwareModuleRepository.findAllById(ids)); } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public boolean exists(final long id) { return softwareModuleRepository.existsById(id); } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public Optional get(final long id) { return softwareModuleRepository.findById(id).map(SoftwareModule.class::cast); } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public Slice findAll(final Pageable pageable) { return JpaManagementHelper.findAllWithoutCountBySpec(softwareModuleRepository, pageable, List.of( SoftwareModuleSpecification.isNotDeleted(), @@ -269,7 +261,6 @@ public Slice findAll(final Pageable pageable) { } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public Page findByRsql(final Pageable pageable, final String rsqlParam) { return JpaManagementHelper.findAllWithCountBySpec(softwareModuleRepository, pageable, List.of( RSQLUtility.buildRsqlSpecification(rsqlParam, SoftwareModuleFields.class, virtualPropertyReplacer, diff --git a/hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/management/JpaSoftwareModuleTypeManagement.java b/hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/management/JpaSoftwareModuleTypeManagement.java index 8425be4ed2..a9b9cd61ce 100644 --- a/hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/management/JpaSoftwareModuleTypeManagement.java +++ b/hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/management/JpaSoftwareModuleTypeManagement.java @@ -83,7 +83,6 @@ public Optional getByName(final String name) { @Transactional @Retryable(retryFor = { ConcurrencyFailureException.class }, maxAttempts = Constants.TX_RT_MAX, backoff = @Backoff(delay = Constants.TX_RT_DELAY)) - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_CREATE_REPOSITORY) public List create(final Collection c) { final List creates = c.stream().map(JpaSoftwareModuleTypeCreate.class::cast) .map(JpaSoftwareModuleTypeCreate::build).toList(); @@ -120,7 +119,6 @@ public SoftwareModuleType update(final SoftwareModuleTypeUpdate u) { } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public long count() { return softwareModuleTypeRepository.count(SoftwareModuleTypeSpecification.isNotDeleted()); } @@ -129,7 +127,6 @@ public long count() { @Transactional @Retryable(retryFor = { ConcurrencyFailureException.class }, maxAttempts = Constants.TX_RT_MAX, backoff = @Backoff(delay = Constants.TX_RT_DELAY)) - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_DELETE_REPOSITORY) public void delete(final long id) { final JpaSoftwareModuleType toDelete = softwareModuleTypeRepository.findById(id) .orElseThrow(() -> new EntityNotFoundException(SoftwareModuleType.class, id)); @@ -141,7 +138,6 @@ public void delete(final long id) { @Transactional @Retryable(retryFor = { ConcurrencyFailureException.class }, maxAttempts = Constants.TX_RT_MAX, backoff = @Backoff(delay = Constants.TX_RT_DELAY)) - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_DELETE_REPOSITORY) public void delete(final Collection ids) { softwareModuleTypeRepository .findAll(AccessController.Operation.DELETE, softwareModuleTypeRepository.byIdsSpec(ids)) @@ -149,32 +145,27 @@ public void delete(final Collection ids) { } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public List get(final Collection ids) { return Collections.unmodifiableList(softwareModuleTypeRepository.findAllById(ids)); } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public boolean exists(final long id) { return softwareModuleTypeRepository.existsById(id); } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public Optional get(final long id) { return softwareModuleTypeRepository.findById(id).map(SoftwareModuleType.class::cast); } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public Slice findAll(final Pageable pageable) { return JpaManagementHelper.findAllWithoutCountBySpec(softwareModuleTypeRepository, pageable, List.of(SoftwareModuleTypeSpecification.isNotDeleted())); } @Override - @PreAuthorize(SpPermission.SpringEvalExpressions.HAS_AUTH_READ_REPOSITORY) public Page findByRsql(final Pageable pageable, final String rsqlParam) { return JpaManagementHelper.findAllWithCountBySpec(softwareModuleTypeRepository, pageable, List.of(