Improved Docker build and docker images #1488
Merged
+121
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
avgustinmm
commented
Nov 27, 2023
avgustinmm
commented
- Using upacked Spring layers for faster boot
- Added option to pass JAVA_OPT to modify the environment variables in both flavours
- Build support for different hawkbit apps - could be used in future if hawkBit is split in multiple micro-services
- Removed templates and replacing with parameterized (via build ARGs) docker builds
|
Can one of the admins verify this patch? |
avgustinmm
force-pushed
the
feature/imporeved_docker_build
branch
2 times, most recently
from
3447c6f to
d87293b
Compare
strailov
reviewed
Nov 27, 2023
There was a problem hiding this comment.
why not leave the shell script ?
There was a problem hiding this comment.
Because it is used to replace some values in templates
no templates are completely drop out. Versions are to be directly passed using build args or replaced in docker files (as defaults)
* Using upacked Spring layers for faster boot * Added option to pass JAVA_OPT to modify the environment variables in both flavours * Build support for different hawkbit apps - could be used in future if hawkBit is split in multiple micro-services * Removed templates and replacing with parameterized (via build ARGs) docker builds Signed-off-by: Marinov Avgustin <Avgustin.Marinov@bosch.com>
avgustinmm
force-pushed
the
feature/imporeved_docker_build
branch
from
d87293b to
5cd9807
Compare
|
updated with some fixes to enable building different apps |
strailov
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.