Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adapt code to latest EDC #168

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Feb 27, 2024

What this PR changes/adds

This PR adapts the FCC code base to the latest changes in upstream EDC, most notably:

  • restores the JsonObjectTo... transformers, that were removed from upstream code in this commit
  • registers the transformers
  • adapts package names / imports for the existing catalog transformers
  • adds the participantId to catalogs in tests

Why it does that

keep in-step with upstream

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added the bug Something isn't working label Feb 27, 2024
@paullatzelsperger paullatzelsperger force-pushed the chore/adapt_to_latest_edc branch from d16929f to 7ab44af Compare February 27, 2024 07:39
Copy link

github-actions bot commented Feb 27, 2024

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit cf8ea9f. ± Comparison against base commit 229610b.

♻️ This comment has been updated with latest results.

@paullatzelsperger paullatzelsperger force-pushed the chore/adapt_to_latest_edc branch from af42f18 to 1dc4f92 Compare February 27, 2024 08:02
@paullatzelsperger paullatzelsperger force-pushed the chore/adapt_to_latest_edc branch from 1dc4f92 to cf8ea9f Compare February 27, 2024 08:23
@paullatzelsperger paullatzelsperger merged commit e893ba3 into main Feb 27, 2024
25 checks passed
@paullatzelsperger paullatzelsperger deleted the chore/adapt_to_latest_edc branch February 27, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants