-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor publisher proto definition #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider my comments, just a few suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Motivation and Context
This change separates out the publisher.proto file into two distinct files. This allows for publishers to implement the callback method without being forced into implementing a 'get_subscription_info' call. That call will be dependent on each publisher and may vary slightly so it has been removed from the required proto.
The 'get_subscription_info' proto definition was moved into the sample code to demonstrate how a publisher could surface the dynamically created topics to a subscriber.
Description
This PR makes the following changes:
NOTE: The 'publisher_impl.rs' files in chariott-publisher and simple-publisher are the exact same.
Additionally: