Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change docker credential type in jenkins #365

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Change docker credential type in jenkins #365

merged 1 commit into from
Apr 26, 2024

Conversation

heurtematte
Copy link
Contributor

@heurtematte heurtematte requested a review from fredg02 April 26, 2024 13:15
@fredg02
Copy link
Contributor

fredg02 commented Apr 26, 2024

Hmm. Shouldn't this PR only contain the change for jenkins-create-credentials-token.sh? 🤔 The other commit is already merged.

@heurtematte
fix: credential type for docker
94cc0ac 
Signed-off-by: sebastien.heurtematte <sebastien.heurtematte@eclipse-foundation.org>
@heurtematte heurtematte force-pushed the fix/docker_credential_type branch from 8ecc1e3 to 94cc0ac Compare April 26, 2024 14:18
@heurtematte
Copy link
Contributor Author

Should be better now 🙂

@fredg02 fredg02 merged commit 7bf739e into master Apr 26, 2024
3 checks passed
@fredg02 fredg02 deleted the fix/docker_credential_type branch April 26, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredg02 fredg02 fredg02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heurtematte @fredg02