Plant Hierarchy inconsistency prevention when deleting subapp #1101
+279
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oberlehner
reviewed
Feb 25, 2025
| class="org.eclipse.fordiac.ide.hierarchymanager.ui.refactoring.DeleteLibraryElementParticipant" | ||
| id="org.eclipse.fordiac.ide.hierarchymanager.ui.deleteLibraryElementParticipant" | ||
| name="deletePlantElement"> | ||
| <enablement></enablement> |
There was a problem hiding this comment.
this should only be possible for Subapp files and system files
|
When i delete sbc
The delete change is not created
And therefore also the subapp is not deleted:
|
|
Another thing: I assigend a nested subapp to the plant hierarchy: Then i delete its parent: PRess save Until here it works fine Then the wrong subapp is created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.