Add some all-purpose sequence Blocks #1060

franz-hoepfinger-4diac · 2025-02-14T13:49:18Z

6 Different Types of sequence FBs:

E --> Event triggered one-Shot
E_looped --> Event triggered looped
T --> Time triggered one-Shot
T_looped --> Time triggered looped
ET --> Event or Time triggered one-Shot
ET_looped --> Event or Time triggered looped

A new XML file was added with global constants for sequence control including initial values.

- Added a new FBType for a sequence with 4 outputs looped - Defined event inputs and outputs, input variables, output variables, and adapter declarations - Implemented ECStates and ECActions for each state transition

…e transitions and algorithms for the looped sequence.

…ansition by EVENT or TIME. Include event inputs/outputs, state transitions, confirmation steps, entry/exit steps for each state.

franz-hoepfinger-4diac · 2025-02-14T13:49:48Z

@bwiesmayr

github-actions · 2025-02-14T13:59:57Z

Test Results

113 files ±0 113 suites ±0 52s ⏱️ +4s
29 183 tests ±0 29 183 ✅ ±0 0 💤 ±0 0 ❌ ±0
29 184 runs ±0 29 184 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit cd4927d. ± Comparison against base commit 1bb26ac.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.

org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.STFunctionValidatorTest ‑ testDuplicateFunctionNameIsForbidden

org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.TypeInferenceTest ‑ testNestedCondition

♻️ This comment has been updated with latest results.

azoitl · 2025-02-15T20:34:08Z

data/typelibrary/utils-1.0.0/typelib/sequence-control/sequence.gcf

+		<VarDeclaration Name="State_08" Type="SINT" Comment="" InitialValue="SINT#8"/>
+	</GlobalConstants>
+	<OriginalSource><![CDATA[VAR_GLOBAL CONSTANT
+	NO_TIME : TIME := TIME#49d17h2m47s295ms;


why is this no time?

This is the largest thinkable Time.
with this Constant you can "switch off" a Transition on Time.

so for the ET Block you make that Transition then Event only.

it could be similar seen as the 0xFFFF for 16-Bit INT for "no Value" which is commonly used in Bus Systems.

This is definitely not the largest possible value for TIME. The largest value how Eclipse 4diac implements it is larger then 290000 years. So it is just some arbitrarily made up value. Which is not good. Why not 0ns or -1ns?

Also the name does not really convey the meaning that you use it for.

-1ns i like most yes !

what do you think about:

INF_TIME : TIME := TIME#-1ns;

T#-1ns is a total valid value for time calling it INF_TIME seems wrong to me. Please note that the Time data type is a delta time so it can be positive and negative. As you need some magic number for your design you should choose one wisely and give it a name that fits to the magic that you are using it for. A generic name will not work here.

azoitl · 2025-02-15T20:34:52Z

data/typelibrary/utils-1.0.0/typelib/sequence-control/sequence.gcf

+	</GlobalConstants>
+	<OriginalSource><![CDATA[VAR_GLOBAL CONSTANT
+	NO_TIME : TIME := TIME#49d17h2m47s295ms;
+	State_00 : SINT := SINT#0;


can you give this states more meaningful names. Just numbers are not really helping to understand what they are for. Would an enum be better?

do we have ENUMS now ?

With the 4days of Eclipse 4diac edition we have basic support for enums in 4diac IDE. However I just noticed that we do not yet have 4diac FORTE support and with that also no exporters. Also as I read below you need the value that is not possible in IEC 611313- with enums. There is a dedicated data type for that, which we are not supporting.

azoitl · 2025-02-15T20:37:12Z

data/typelibrary/utils-1.0.0/typelib/sequence-control/time/sequence_T_04.fbt

+			</Event>
+		</EventInputs>
+		<EventOutputs>
+			<Event Name="CNF" Type="Event" Comment="Execution Confirmation" >


why do you have cnf and individual events for states?

CNF goes with the State Number, to display current Step in a Display,
the individual Events go for the Individual Outputs

interesting approach

we could also make CNF and RO like written below.

azoitl · 2025-02-15T20:37:50Z

data/typelibrary/utils-1.0.0/typelib/sequence-control/time/sequence_T_04.fbt

+				<ECAction Output="timeOut.STOP"/>
+			</ECState>
+			<ECState Name="sRESET" x="-666.67" y="2666.67">
+				<ECAction Algorithm="State_01_X" Output="EO_S1"/>


do you really want to issue all EO events in case of reset?

yes, otherwise the Outputs stay on if we go with the Concept you see in the Comment above.

Question is if we want to reset the STATE_NR Output also to 0.

This is different to other FBs with Reset inputs.

as my resarch no:
E_TOF.fbt if we press 'R' all Outputs go to FALSE.
do you know any where the Outputs stay on ?

I'm not talking about the values I'm talking about the events that are sent on reset.

if we go so:

then we need all this Events,

if we don't, i would make it like E_CTU, where we have R and RO,
to have a dedicated Reset Output Event ?

right ?

Yes this was what I wanted to point out. But as I do not really understand what the block is doing and what you need it for it is hard for me to say what a good design is.

Traffic Light Example:
"Austria"

"International"

@azoitl as said,
a all-purpose Seqence control,
avoiding everybody must go the C++ way for simple Sequences.

Pneumatic, Hydraulic, Traffic Light, etc..

also add a State for reseting the Counter to 0 on Reset.

…tput. - Refactored event names in EventOutputs section - Changed timing values to INF_TIME in InputVars section - Added new event "RO" with associated variables in EventOutputs section

franz-hoepfinger-4diac · 2025-02-17T06:18:45Z

@azoitl
sequence_ET_04.fbt
i have adjusted this one now.
if OK, i will change all to this Schema.

is more 61499-ish.

Thanks,
Franz

franz-hoepfinger-4diac added 4 commits February 14, 2025 14:47

Add sequence control global constants to typelib

18337c2

A new XML file was added with global constants for sequence control including initial values.

Add new sequence control FBType with 4 outputs looped by TIME.

414a152

- Added a new FBType for a sequence with 4 outputs looped - Defined event inputs and outputs, input variables, output variables, and adapter declarations - Implemented ECStates and ECActions for each state transition

Add new sequence control event files with looped outputs. Update stat…

2c83d00

…e transitions and algorithms for the looped sequence.

Add sequence_ET_04 and sequence_ET_04_loop FBTypes with 4 outputs, tr…

3cbfd92

…ansition by EVENT or TIME. Include event inputs/outputs, state transitions, confirmation steps, entry/exit steps for each state.

azoitl requested changes Feb 15, 2025

View reviewed changes

franz-hoepfinger-4diac added 3 commits February 16, 2025 10:13

Update sequence Control Blocks so that the Reset is always last in XML

700da46

also add a State for reseting the Counter to 0 on Reset.

Update sequence.gcf

b74cbd4

Update event names and timing values, add new event "RO" for reset ou…

cd4927d

…tput. - Refactored event names in EventOutputs section - Changed timing values to INF_TIME in InputVars section - Added new event "RO" with associated variables in EventOutputs section

franz-hoepfinger-4diac requested a review from azoitl February 18, 2025 08:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add some all-purpose sequence Blocks #1060

Add some all-purpose sequence Blocks #1060

franz-hoepfinger-4diac commented Feb 14, 2025 •

edited

Loading

franz-hoepfinger-4diac commented Feb 14, 2025

github-actions bot commented Feb 14, 2025 •

edited

Loading

azoitl Feb 15, 2025

franz-hoepfinger-4diac Feb 16, 2025

franz-hoepfinger-4diac Feb 16, 2025

azoitl Feb 16, 2025

franz-hoepfinger-4diac Feb 16, 2025

franz-hoepfinger-4diac Feb 16, 2025

azoitl Feb 16, 2025

azoitl Feb 15, 2025

franz-hoepfinger-4diac Feb 16, 2025

azoitl Feb 16, 2025

azoitl Feb 15, 2025

franz-hoepfinger-4diac Feb 16, 2025

azoitl Feb 16, 2025

franz-hoepfinger-4diac Feb 16, 2025

azoitl Feb 15, 2025

franz-hoepfinger-4diac Feb 16, 2025 •

edited

Loading

azoitl Feb 16, 2025

franz-hoepfinger-4diac Feb 16, 2025

azoitl Feb 16, 2025

franz-hoepfinger-4diac Feb 16, 2025

azoitl Feb 16, 2025

franz-hoepfinger-4diac Feb 16, 2025

franz-hoepfinger-4diac Feb 16, 2025

franz-hoepfinger-4diac commented Feb 17, 2025

Add some all-purpose sequence Blocks #1060

Are you sure you want to change the base?

Add some all-purpose sequence Blocks #1060

Conversation

franz-hoepfinger-4diac commented Feb 14, 2025 • edited Loading

franz-hoepfinger-4diac commented Feb 14, 2025

github-actions bot commented Feb 14, 2025 • edited Loading

Test Results

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

franz-hoepfinger-4diac Feb 16, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

franz-hoepfinger-4diac commented Feb 17, 2025

franz-hoepfinger-4diac commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

franz-hoepfinger-4diac Feb 16, 2025 •

edited

Loading