Fix compile errors for VS Build Tools 2019 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumajaya
commented
Feb 28, 2024
azoitl
reviewed
Feb 28, 2024
| #include <sys/types.h> | ||
| #include <sys/stat.h> | ||
| #include <fcntl.h> | ||
| #ifndef WIN32 | ||
| #include <unistd.h> // for sleep |
There was a problem hiding this comment.
I think the better solution for this file is not to fix that here but use CThread::sleepThread( instead of sleep. Because the CThread::sleepThread( we do the hardware/OS abstraction allready.
src/core/datatypes/forte_wstring.h
Outdated
| @@ -52,13 +52,22 @@ class CIEC_WSTRING final : public CIEC_ANY_STRING { | |||
| TForteWChar value = static_cast<TForteWChar>(paValue); | |||
| auto &converter = std::use_facet<std::codecvt<char16_t, char, std::mbstate_t>>(std::locale()); | |||
| std::mbstate_t mb{}; | |||
| #ifdef _MSC_VER | |||
There was a problem hiding this comment.
I don't think in this case it makes sense to have two versions. I would prefer to only have the one that compiles for all systems.
kumajaya
force-pushed
the
fix/msbuild
branch
from
63a6932 to
276b409
Compare
azoitl
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.