Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create io handle #20

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Create io handle #20

merged 1 commit into from
Feb 23, 2024

Conversation

azoitl
Copy link
Contributor

@azoitl azoitl commented Feb 22, 2024

No description provided.

MartinMelikMerkumians
MartinMelikMerkumians reviewed Feb 23, 2024
View reviewed changes
Copy link
Member

@MartinMelikMerkumians MartinMelikMerkumians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also replicate the changes in PR #19 ?

@azoitl
Copy link
Contributor Author

azoitl commented Feb 23, 2024

Does this also replicate the changes in PR #19 ?

It builds on PR #19. Therefore it has the same base commit. So please first merge PR #19 then this one should be more clear.

@azoitl
Renamed initHandle to createIOHandle to better reflect the task
58f882b 
Also this allows to better distinquish from a second initHandle used for
registering handles.
@MartinMelikMerkumians MartinMelikMerkumians merged commit acb24eb into eclipse-4diac:develop Feb 23, 2024
3 checks passed
@azoitl azoitl deleted the createIOHandle branch February 23, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinMelikMerkumians MartinMelikMerkumians MartinMelikMerkumians approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azoitl @MartinMelikMerkumians