Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BSD socket interface receive functions #18

Merged
merged 3 commits into from
Feb 25, 2024

Conversation

franz-hoepfinger-4diac
Copy link

  • Handle different error cases in receiveDataFromTCP and receiveDataFromUDP
  • Log specific error messages for disconnection scenarios
  • Return 0 when the connection is closed by the peer

- Handle different error cases in receiveDataFromTCP and receiveDataFromUDP
- Log specific error messages for disconnection scenarios
- Return 0 when the connection is closed by the peer
- Added a new method to handle errors in TCP and UDP data reception.
- Updated error handling logic in receiveDataFromTCP and receiveDataFromUDP functions.
Consolidate error handling function for TCP and UDP sockets.
@azoitl azoitl merged commit 5293804 into eclipse-4diac:develop Feb 25, 2024
3 checks passed
@diplfranzhoepfinger
Copy link

@diplfranzhoepfinger
Copy link

espressif/esp-idf#13133

@azoitl
Copy link
Contributor

azoitl commented Mar 11, 2024

espressif/esp-idf#13133

I'm now curious why we shouldn't clearly close the connection. From 4diac IDE side we definitely do that. The only problem that could arrise is that there is a timeout in 4diac IDE if the device is not responding with xxxms to close the socket on our side. But then we assume the device has died or the connection is broken (e.g., cable disconnected). As other implementations are fine with how we are interacting with 4diac FORTE I still assume it is an esp32 problem.

@diplfranzhoepfinger
Copy link

#18 was merged and to me it seems it works very good. 

we lost the Error Messages here, due to the Move from Gerrit to Github:

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=582098

@diplfranzhoepfinger
Copy link

diplfranzhoepfinger commented Mar 11, 2024

this was the Error:

it is solved now.

@diplfranzhoepfinger
Copy link

i must add here another Log, so we see how the Behaviour is on a Close of Eclipse 4diac IDE. 

otherwise these knowledge gets lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants