Refactor error handling in socket interface functions

- Added a new method to handle errors in TCP and UDP data reception.
- Updated error handling logic in receiveDataFromTCP and receiveDataFromUDP functions.

src/arch/bsdsocketinterf.cpp

@@ -137,40 +137,47 @@ int CBSDSocketInterface::sendDataOnTCP(TSocketDescriptor paSockD, const char* pa
   return nRetVal;
 }
 
-int CBSDSocketInterface::receiveDataFromTCP(TSocketDescriptor paSockD, char* paData,
-    unsigned int paBufSize){
-  int nRetVal;
-  do{
-    nRetVal = static_cast<int>(recv(paSockD, paData, paBufSize, 0));
-  } while((-1 == nRetVal) && (EINTR == errno)); // recv got interrupt / recieving again
-
-  if(nRetVal == -1){
-    DEVLOG_ERROR("CBSDSocketInterface: TCP-Socket recv() failed: %s\n", strerror(errno));
-  }
-
+int CBSDSocketInterface::handleError(int nRetVal, int err, const char* msg) {
   // recv only sets errno if res is <= 0
   if(nRetVal <= 0) {
     switch(errno){
       case EWOULDBLOCK:
       case ENOENT: //caused by vfs
-        //TODO: this is a "connected = true" case, for the moment we leave it open.
+        //connected = true;
         break;
       case ENOTCONN:
       case EPIPE:
       case ECONNRESET:
       case ECONNREFUSED:
       case ECONNABORTED:
-        DEVLOG_ERROR("CBSDSocketInterface::receiveDataFromTCP recv() Disconnected: nRetVal: %d, ERR: %d %s\n", nRetVal, errno, strerror(errno));
+        //connected = false;
+        DEVLOG_ERROR("CBSDSocketInterface::receiveDataFrom%s  recv() Disconnected: nRetVal: %d, ERR: %d %s\n", msg, nRetVal, errno, strerror(errno));
         return 0; //Connection closed by peer
       default:
-        DEVLOG_ERROR("CBSDSocketInterface::receiveDataFromTCP recv() Unexpected: nRetVal: %d, ERR: %d %s\n", nRetVal, errno, strerror(errno));
-        //TODO: this is a "connected = true" case, for the moment we leave it open.
+        DEVLOG_ERROR("CBSDSocketInterface::receiveDataFrom%s recv() Unexpected: nRetVal: %d, ERR: %d %s\n", msg, nRetVal, errno, strerror(errno));
+        //connected = true;
         break;
     }
   }
   return nRetVal;
 }
 
+
+
+
+int CBSDSocketInterface::receiveDataFromTCP(TSocketDescriptor paSockD, char* paData,
+    unsigned int paBufSize){
+  int nRetVal;
+  do{
+    nRetVal = static_cast<int>(recv(paSockD, paData, paBufSize, 0));
+  } while((-1 == nRetVal) && (EINTR == errno)); // recv got interrupt / recieving again
+
+  if(nRetVal == -1){
+    DEVLOG_ERROR("CBSDSocketInterface: TCP-Socket recv() failed: %s\n", strerror(errno));
+  }
+  return handleError(nRetVal, errno, "TCP");
+}
+
 CBSDSocketInterface::TSocketDescriptor CBSDSocketInterface::openUDPSendPort(char *paIPAddr,
     unsigned short paPort, TUDPDestAddr *mDestAddr, const char *paMCInterface){
   DEVLOG_INFO("CBSDSocketInterface: Opening UDP sending connection at: %s:%d\n", paIPAddr, paPort);
@@ -309,25 +316,5 @@ int CBSDSocketInterface::receiveDataFromUDP(TSocketDescriptor paSockD, char* paD
     DEVLOG_ERROR("CBSDSocketInterface: UDP-Socket recvfrom() failed: %s\n", strerror(errno));
   }
 
-  // recv only sets errno if res is <= 0
-  if(nRetVal <= 0) {
-    switch(errno){
-      case EWOULDBLOCK:
-      case ENOENT: //caused by vfs
-        //TODO: this is a "connected = true" case, for the moment we leave it open.
-        break;
-      case ENOTCONN:
-      case EPIPE:
-      case ECONNRESET:
-      case ECONNREFUSED:
-      case ECONNABORTED:
-        DEVLOG_ERROR("CBSDSocketInterface::receiveDataFromUDP recvfrom() Disconnected: nRetVal: %d, ERR: %d %s\n", nRetVal, errno, strerror(errno));
-        return 0; //Connection closed by peer
-      default:
-        DEVLOG_ERROR("CBSDSocketInterface::receiveDataFromUDP recvfrom() Unexpected: nRetVal: %d, ERR: %d %s\n", nRetVal, errno, strerror(errno));
-        //TODO: this is a "connected = true" case, for the moment we leave it open.
-        break;
-    }
-  }
-  return nRetVal;
+  return handleError(nRetVal, errno, "UDP");
 }

src/arch/bsdsocketinterf.h

@@ -33,6 +33,10 @@ class CBSDSocketInterface{
     static int sendDataOnUDP(TSocketDescriptor paSockD, TUDPDestAddr *paDestAddr, char* paData, unsigned int paSize);
     static int receiveDataFromUDP(TSocketDescriptor paSockD, char* paData, unsigned int paBufSize);
 
+
+    static int handleError(int nRetVal, int err, const char* msg);
+
+
     CBSDSocketInterface() = delete;
 };