MQTT: Set username and password as local variables

eclipse-4diac · Feb 26, 2024 · 0fade00 · 0fade00
1 parent d0e8235
commit 0fade00
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/com/mqtt_paho/MQTTClient.cpp b/src/com/mqtt_paho/MQTTClient.cpp
@@ -189,9 +189,10 @@ int CMQTTClient::initClient() {
   mClientConnectionOptions.context = this;
 
   if ("" != gMqttClientConfigFile) { //file was provided
+    std::string mUsername;
+    std::string mPassword;
     CMQTTClientConfigFileParser::MQTTConfigFromFile result = CMQTTClientConfigFileParser::MQTTConfigFromFile(mUsername, mPassword);
-    std::string endpoint = mAddress;
-    if(CMQTTClientConfigFileParser::loadConfig(gMqttClientConfigFile, endpoint, result)) {
+    if (CMQTTClientConfigFileParser::loadConfig(gMqttClientConfigFile, mAddress, result)) {
       mClientConnectionOptions.username = mUsername.c_str();
       mClientConnectionOptions.password = mPassword.c_str();
     } else {

diff --git a/src/com/mqtt_paho/MQTTClient.h b/src/com/mqtt_paho/MQTTClient.h
@@ -91,8 +91,6 @@ class CMQTTClient {
 
   std::string mAddress;
   std::string mClientId;
-  std::string mUsername;
-  std::string mPassword;
 
   MQTTAsync mAsClient;
   MQTTAsync_connectOptions mClientConnectionOptions;