-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for integer serial number in device URL #210
base: master
Are you sure you want to change the base?
Conversation
|
Sorry I misread the code. |
I intended to leave support for current styles (but sort-of deprecate using index field for serial number, since it is unreliable anyway). |
Maybe it is time to break compatibility with index-based syntax, (re-)using your proposed syntax:
? |
That would certainly work for me, as I don't need the backwards compatibility. And it's much simpler overall. |
Ok, as I just need to find some spare time to implement it (and test & document it...) |
I would also prefer prioritizing serial number over index :) I have till now used this field as a serial number, in my organization we use integer serial numbers so I had to add literal prefix to use pyftdi. This causes an inconsistencies with other platforms which do not have such an issue, and questions why devices which work with "python apps" must be marked differently. |
I'm ok with that. I think I will remove the index support for now... |
How about leaving specifier[2] as it is now (serial or device number), but add support for specifier[3] being serial number only. I'd open it with
bitbang.open_bitbang_from_url("ftdi://vid:pid::0025/1")
instead.Resolved #209