Skip to content

Commit

Permalink
fix: render no manifest error
Browse files Browse the repository at this point in the history
  • Loading branch information
sky committed Jun 27, 2019
1 parent 7f338e7 commit 2f8fa10
Show file tree
Hide file tree
Showing 3 changed files with 40 additions and 2 deletions.
5 changes: 4 additions & 1 deletion lib/view.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ class View {
locals = this.app.vue.normalizeLocals(this.ctx, locals, options);
const context = { state: locals };
return this.app.vue.render(name, context, options).then(html => {
return this.app.vue.resource.inject(html, options.name, context, options);
if (this.app.vue.resource) {
return this.app.vue.resource.inject(html, options.name, context, options);
}
return html;
}).catch(err => {
if (this.config.fallbackToClient) {
this.app.logger.error('[%s] server render bundle error, try client render, the server render error', name, err);
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "egg-view-vue-ssr",
"version": "3.3.0",
"version": "3.3.1",
"description": "vue server side render solution for egg",
"eggPlugin": {
"name": "vuessr"
Expand Down
35 changes: 35 additions & 0 deletions test/view-vue-ssr.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,4 +175,39 @@ describe('test/view-vue-ssr.test.js', () => {
});
});
});

describe('vue server render no manifest test', () => {
let app;
before(() => {
app = mm.app({
baseDir: 'apps/view-vue-ssr-test2',
});
return app.ready();
});

after(() => app.close());
afterEach(mm.restore);

it('should GET /render', () => {
return request(app.callback())
.get('/render')
.expect(200)
.expect(res => {
assert(res.text.indexOf('data-server-rendered="true"') > -1);
assert(res.text.indexOf('</body></html>') > -1);
assert(res.text.indexOf('<title>app_locals_render_ssr</title>') > -1);
assert(res.text.indexOf('vue server side render!') > -1);
});
});

it('should GET /renderClient', () => {
return request(app.callback())
.get('/renderClient')
.expect(200)
.expect(res => {
assert(res.text.indexOf('data-server-rendered="true"') > -1);
assert(res.text.indexOf('name="client"') > -1);
});
});
});
});

0 comments on commit 2f8fa10

Please sign in to comment.