Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved generation location and updated install step #354

Conversation

makepath-alex
Copy link
Collaborator

  • Moved all generated header files to <build_dir>/headers
  • Added all header files in the install step

@makepath-alex makepath-alex marked this pull request as draft February 6, 2025 10:04
@makepath-alex makepath-alex force-pushed the better-header-placement-dev branch from d6bea54 to 7980400 Compare February 10, 2025 09:41
@makepath-alex makepath-alex marked this pull request as ready for review February 11, 2025 12:00
Copy link
Member

@RobertPincus RobertPincus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skosukhin This seems ok to me but I don't understand it deeply and would be grateful for your eyes.

tau, & ! Optical depth (tau)
gamma1, gamma2,& ! Coupling coefficients
rdif, tdif ! Layer reflectance and transmittance
real(wp), dimension(ncol, nlay), intent(in) :: lay_source ! Planck source at layer center
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required since our automated header generator does not support multiline variable initialization

@RobertPincus RobertPincus merged commit 0c51fa2 into earth-system-radiation:main Feb 12, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants