Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-processing write example #779

Merged
merged 4 commits into from
Feb 27, 2025
Merged

Add multi-processing write example #779

merged 4 commits into from
Feb 27, 2025

Conversation

dcherian
Copy link
Contributor

cc @ianhi

@dcherian dcherian requested a review from ianhi February 25, 2025 21:09
@ianhi
Copy link
Contributor

ianhi commented Feb 25, 2025

We need to explain to the reader why the code on the page is not standalone executable (I believe because of the need to wrap in __main__ checks?). After that then we can eliminate some of the setup code in the examples and just show the core loop.

Also if we are going to keep the script separate from the main text we should execute it as part of the tests.

@dcherian
Copy link
Contributor Author

We need to explain to the reader why the code on the page is not standalone executable

I added a line.

Also if we are going to keep the script separate from the main text we should execute it as part of the tests.

tracking here: #780

@dcherian dcherian enabled auto-merge (squash) February 27, 2025 17:28
@dcherian dcherian merged commit 1c60e5b into main Feb 27, 2025
5 checks passed
@dcherian dcherian deleted the mp-write-example branch February 27, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants