Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ready for review] Icechunk CLI Initial Implementation #716
base: main
Are you sure you want to change the base?
[Ready for review] Icechunk CLI Initial Implementation #716
Changes from 14 commits
ad4847b
e166f1e
a819028
d3ec0da
a2778a1
6236b0a
1dbd8b5
3f31866
5b6c181
449d984
3acf5d5
94941dd
7c79219
691dd8c
18d4d08
4d7afda
5b03fbd
6d096e3
c464462
7cdd087
1c857e6
8f8d89f
38747c1
a02365b
1724fcd
4ac073b
2593843
6feea11
3137ace
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move this file src/bin/icechunk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now removed the file altogether (5b03fbd), since it can be generated by
icechunk config init
Should we instead decide on a standard location for the config, not relative to the repo? How about
$HOME/.config/icechunk/cli_config.yaml
, obtained through dirs::config_dir()?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did that here 8f8d89f
On Mac, this actually defaults to
$HOME/Library/Application Support
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably return an error, something like:
we will want the status code to be != 0 if some error happened
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improved error handling in 1724fcd