Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding cargo-semver-checks to CI #702

Open
LDeakin opened this issue Feb 8, 2025 · 0 comments
Open

Consider adding cargo-semver-checks to CI #702

LDeakin opened this issue Feb 8, 2025 · 0 comments

Comments

@LDeakin
Copy link
Contributor

LDeakin commented Feb 8, 2025

The icechunk 0.1.2 Rust crate release had a few breaking changes, so it is probably worth adding cargo-semver-checks to your CI.

cargo semver-checks --baseline-version 0.1.1 -p icechunk
    Building icechunk v0.1.2 (current)
       Built [   1.783s] (current)
     Parsing icechunk v0.1.2 (current)
      Parsed [   0.039s] (current)
     Parsing icechunk v0.1.1 (baseline, cached)
      Parsed [   0.038s] (baseline)
    Checking icechunk v0.1.1 -> v0.1.2 (minor change)
     Checked [   0.028s] 120 checks: 118 pass, 2 fail, 0 warn, 7 skip

--- failure enum_missing: pub enum removed or renamed ---

Description:
A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/enum_missing.ron

Failed in:
  enum icechunk::repository::RepositoryError, previously in file /home/ljd/.cargo/registry/src/index.crates.io-6f17d22bba15001f/icechunk-0.1.1/src/repository.rs:44
  enum icechunk::store::StoreError, previously in file /home/ljd/.cargo/registry/src/index.crates.io-6f17d22bba15001f/icechunk-0.1.1/src/store.rs:58
  enum icechunk::format::IcechunkFormatError, previously in file /home/ljd/.cargo/registry/src/index.crates.io-6f17d22bba15001f/icechunk-0.1.1/src/format/mod.rs:218
  enum icechunk::storage::StorageError, previously in file /home/ljd/.cargo/registry/src/index.crates.io-6f17d22bba15001f/icechunk-0.1.1/src/storage/mod.rs:61
  enum icechunk::StorageError, previously in file /home/ljd/.cargo/registry/src/index.crates.io-6f17d22bba15001f/icechunk-0.1.1/src/storage/mod.rs:61
  enum icechunk::format::manifest::VirtualReferenceError, previously in file /home/ljd/.cargo/registry/src/index.crates.io-6f17d22bba15001f/icechunk-0.1.1/src/format/manifest.rs:31
  enum icechunk::refs::RefError, previously in file /home/ljd/.cargo/registry/src/index.crates.io-6f17d22bba15001f/icechunk-0.1.1/src/refs.rs:33
  enum icechunk::session::SessionError, previously in file /home/ljd/.cargo/registry/src/index.crates.io-6f17d22bba15001f/icechunk-0.1.1/src/session.rs:46

--- failure function_parameter_count_changed: pub fn parameter count changed ---

Description:
A publicly-visible function now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/function_parameter_count_changed.ron

Failed in:
  icechunk::ops::gc::expire now takes 6 parameters instead of 4, in /home/ljd/dev/icechunk/icechunk/src/ops/gc.rs:491

     Summary semver requires new major version: 2 major and 0 minor checks failed
    Finished [   3.539s] icechunk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant