refactor

earth-mover · Feb 17, 2025 · f463f7c · f463f7c
1 parent 42e40ca
commit f463f7c
Showing 1 changed file with 18 additions and 19 deletions.
diff --git a/icechunk-python/benchmarks/runner.py b/icechunk-python/benchmarks/runner.py
@@ -151,6 +151,24 @@ def initialize(self) -> None:
 
     def run(self, *, pytest_extra: str = "") -> None:
         super().run(pytest_extra=pytest_extra)
+        if len(refs) > 1:
+            files = sorted(
+                glob.glob("./.benchmarks/**/*.json", recursive=True),
+                key=os.path.getmtime,
+                reverse=True,
+            )[-len(refs) :]
+            # TODO: Use `just` here when we figure that out.
+            subprocess.run(
+                [
+                    "pytest-benchmark",
+                    "compare",
+                    "--group=group,func,param",
+                    "--sort=fullname",
+                    "--columns=median",
+                    "--name=normal",
+                    *files,
+                ]
+            )
 
 
 class CoiledRunner(Runner):
@@ -262,25 +280,6 @@ def init_for_ref(runner: Runner):
     for runner in tqdm.tqdm(runners):
         runner.run(pytest_extra=args.pytest)
 
-    if len(refs) > 1:
-        files = sorted(
-            glob.glob("./.benchmarks/**/*.json", recursive=True),
-            key=os.path.getmtime,
-            reverse=True,
-        )[-len(refs) :]
-        # TODO: Use `just` here when we figure that out.
-        subprocess.run(
-            [
-                "pytest-benchmark",
-                "compare",
-                "--group=group,func,param",
-                "--sort=fullname",
-                "--columns=median",
-                "--name=normal",
-                *files,
-            ]
-        )
-
 
 # Compare wish-list:
 # 1. skip differences < X%