-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[22721] Increase 'max_blocking_time' in Easy Mode #5617
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
MiguelCompany
requested changes
Jan 30, 2025
6 tasks
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
cferreiragonz
force-pushed
the
increase_mbt_easy_mode
branch
from
January 30, 2025 15:08
b94efd5
to
d28aadf
Compare
cferreiragonz
requested review from
richiprosima
and removed request for
richiprosima
January 30, 2025 15:08
MiguelCompany
previously approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
cferreiragonz
force-pushed
the
increase_mbt_easy_mode
branch
from
January 31, 2025 07:10
d28aadf
to
5cef70e
Compare
MiguelCompany
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
MiguelCompany
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a Discovery Server as central discovery point might introduce small delays in discovery in resource limited CPUs. When using services in ROS2, this might cause some of the server's responses to fail due to timeout. However, the
max_blocking_time
can be automatically increased for services in Easy Mode.Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist