Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22713] Add replace tag to package.xml (backport #5608) #5609

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 30, 2025

Description

This adds the replace tag to the package.xml file so fastrtps package would be uninstalled when installing fastdds.

@Mergifyio backport 3.1.x 3.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • N/A: The code follows the style guidelines of this project.

  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A: Any new/modified methods have been properly documented using Doxygen.

  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A: New feature has been added to the versions.md file (if applicable).

  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • N/A: Check CI results: changes do not issue any warning.
  • N/A: Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5608 done by [Mergify](https://mergify.com).

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 886adcc)
@mergify mergify bot mentioned this pull request Jan 30, 2025
7 tasks
@MiguelCompany MiguelCompany added this to the v3.1.2 milestone Jan 30, 2025
@MiguelCompany MiguelCompany added the skip-ci Automatically pass CI label Jan 30, 2025
@MiguelCompany MiguelCompany merged commit ea2a074 into 3.1.x Jan 30, 2025
3 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/3.1.x/pr-5608 branch January 30, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant