Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22713] Add replace tag to package.xml #5608

Merged
merged 1 commit into from
Jan 30, 2025
Merged

[22713] Add replace tag to package.xml #5608

merged 1 commit into from
Jan 30, 2025

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Jan 29, 2025 •
edited
Loading

Description

This adds the replace tag to the package.xml file so fastrtps package would be uninstalled when installing fastdds.

@Mergifyio backport 3.1.x 3.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • N/A: Check CI results: changes do not issue any warning.
  • N/A: Check CI results: failing tests are unrelated with the changes.

@MiguelCompany
Refs #22713. Add replace tag to package.xml.
6635616 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany added the skip-ci Automatically pass CI label Jan 29, 2025
@MiguelCompany MiguelCompany added this to the v3.2.0 milestone Jan 29, 2025
@EugenioCollado EugenioCollado self-requested a review January 30, 2025 07:31
EugenioCollado
EugenioCollado approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@EugenioCollado EugenioCollado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 886adcc into master Jan 30, 2025
14 checks passed
@MiguelCompany MiguelCompany deleted the feature/22713 branch January 30, 2025 08:15
@MiguelCompany
Copy link
Member Author

@Mergifyio backport 3.1.x 3.0.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 30, 2025 •
edited
Loading

backport 3.1.x 3.0.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 30, 2025
@MiguelCompany @mergify
Add replace tag to package.xml (#5608)
a70c999 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 886adcc)
@mergify mergify bot mentioned this pull request Jan 30, 2025
Merged
7 tasks
mergify bot pushed a commit that referenced this pull request Jan 30, 2025
@MiguelCompany @mergify
Add replace tag to package.xml (#5608)
0a7da36 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 886adcc)
@mergify mergify bot mentioned this pull request Jan 30, 2025
Merged
7 tasks
MiguelCompany added a commit that referenced this pull request Jan 30, 2025
@mergify @MiguelCompany
Add replace tag to package.xml (#5608) (#5609)
ea2a074 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 886adcc)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Feb 3, 2025
@mergify @MiguelCompany
Add replace tag to package.xml (#5608) (#5610)
42b67a0 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 886adcc)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
RookieCLY pushed a commit to RookieCLY/Fast-DDS that referenced this pull request Feb 6, 2025
@MiguelCompany @RookieCLY
Add replace tag to package.xml (eProsima#5608)
439100d 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: RookieCLY <2238379153@qq.com>
RookieCLY pushed a commit to RookieCLY/Fast-DDS that referenced this pull request Feb 6, 2025
@MiguelCompany @RookieCLY
Add replace tag to package.xml (eProsima#5608)
339518a 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: RookieCLY <2238379153@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EugenioCollado EugenioCollado EugenioCollado approved these changes

Assignees
No one assigned
Labels
skip-ci Automatically pass CI
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @EugenioCollado