Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22277] Split Windows nightly tests using name filter regex #5498

Merged
merged 6 commits into from
Jan 17, 2025
Merged

[22277] Split Windows nightly tests using name filter regex #5498

merged 6 commits into from
Jan 17, 2025

Conversation

rsanchez15
Copy link
Contributor

@rsanchez15 rsanchez15 commented Dec 16, 2024 •
edited
Loading

Description

This PR splits Fast DDS tests, and runs some of them in parallel, to avoid exceeding the maximum allowed GitHub Workflow time.

Windows Nightly CI run:
https://github.com/eProsima/Fast-DDS/actions/runs/12687477053

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@rsanchez15 rsanchez15 force-pushed the ci/split-tests branch 3 times, most recently from 7094c71 to c046ae9 Compare December 17, 2024 08:01
@rsanchez15 rsanchez15 changed the title Split Windows nightly tests using name filter regex [22277] Split Windows nightly tests using name filter regex Dec 17, 2024
@rsanchez15 rsanchez15 force-pushed the ci/split-tests branch 2 times, most recently from 6c68c7a to 407114a Compare December 17, 2024 14:46
@MiguelCompany MiguelCompany force-pushed the ci/split-tests branch 3 times, most recently from ffc2c04 to e6727cd Compare January 9, 2025 09:49
@MiguelCompany MiguelCompany added the skip-ci Automatically pass CI label Jan 9, 2025
@MiguelCompany MiguelCompany added this to the v3.2.0 milestone Jan 9, 2025
@MiguelCompany MiguelCompany requested a review from Mario-DL January 9, 2025 10:06
Mario-DL
Mario-DL previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
It is funny that we have a typo in the SecureDiscoveryServer tests.
We will address the failing tests in Debug in a follow up PR

rsanchez15 and others added 6 commits January 16, 2025 10:41
@rsanchez15 @MiguelCompany
Split test using name filter regex
9e44964 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@MiguelCompany
Run unit tests in parallel
c71018a 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Use matrix variable to define test expresion
306302e 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Add more tests to sequential job
53c627a 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Customize job name
8e69b34 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Reorder matrix
f65e893 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Copy link
Member

Latest run in https://github.com/eProsima/Fast-DDS/actions/runs/12806591865

rsanchez15
rsanchez15 commented Jan 17, 2025
View reviewed changes
Copy link
Contributor Author

@rsanchez15 rsanchez15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Mario-DL
Mario-DL approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 90bebe3 into master Jan 17, 2025
18 of 22 checks passed
@MiguelCompany MiguelCompany deleted the ci/split-tests branch January 17, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees
No one assigned
Labels
skip-ci Automatically pass CI
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rsanchez15 @MiguelCompany @Mario-DL