[21660] Add `flow_control`, `rtps`, `custom_payload_pool` and `content_filter` to windows example ci testing #5480

Mario-DL · 2024-12-10T15:57:26Z

Description

This PR adds the flow_control, rtps, custom_payload_pool and content_filter to windows example ci testing.
In particular, it

Adds the required infrastructure to include environment args splitting them to be recognized as different argv in windows.
Includes a new matched argument to the rtps example to wait for discovery before publishing.
Adds a new argument samples to the subscriber content filter as a finish condition when it gets unmatched.

Note: In the content filter example the PUB_ARGS was removed since it was not being used in the compose file.

@Mergifyio backport 3.1.x 3.0.x

Contributor Checklist

[X ] Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

Mario-DL · 2024-12-13T08:22:33Z

@Mergifyio backport 3.1.x 3.0.x

mergify · 2024-12-13T08:22:49Z

backport 3.1.x 3.0.x

✅ Backports have been created

#5490 [21660] Add flow_control, rtps, custom_payload_pool and content_filter to windows example ci testing (backport #5480) has been created for branch 3.1.x but encountered conflicts
#5491 [21660] Add flow_control, rtps, custom_payload_pool and content_filter to windows example ci testing (backport #5480) has been created for branch 3.0.x but encountered conflicts

…` to windows example ci testing (#5480) * Refs #21660: Flow controller example Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21660: RTPS example Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21660: Custom PayloadPool example Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21660: Additional cmake vars for configuring extra arguments lists Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21660: Content Filter example Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21660: Add examples to CMakeLists.txt Signed-off-by: Mario-DL <mariodominguez@eprosima.com> --------- Signed-off-by: Mario-DL <mariodominguez@eprosima.com> (cherry picked from commit 0deeb14) # Conflicts: # test/examples/CMakeLists.txt # test/examples/content_filter.compose.yml # test/examples/custom_payload_pool.compose.yml # test/examples/rtps.compose.yml

…` to windows example ci testing (#5480) * Refs #21660: Flow controller example Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21660: RTPS example Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21660: Custom PayloadPool example Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21660: Additional cmake vars for configuring extra arguments lists Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21660: Content Filter example Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21660: Add examples to CMakeLists.txt Signed-off-by: Mario-DL <mariodominguez@eprosima.com> --------- Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

…` to windows example ci testing (#5480) (#5490) * Refs #21660: Flow controller example * Refs #21660: RTPS example * Refs #21660: Custom PayloadPool example * Refs #21660: Additional cmake vars for configuring extra arguments lists * Refs #21660: Content Filter example * Refs #21660: Add examples to CMakeLists.txt --------- Signed-off-by: Mario-DL <mariodominguez@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>

…` to windows example ci testing (#5480) * Refs #21660: Flow controller example Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21660: RTPS example Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21660: Custom PayloadPool example Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21660: Additional cmake vars for configuring extra arguments lists Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21660: Content Filter example Signed-off-by: Mario-DL <mariodominguez@eprosima.com> * Refs #21660: Add examples to CMakeLists.txt Signed-off-by: Mario-DL <mariodominguez@eprosima.com> --------- Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

Mario-DL added 4 commits December 10, 2024 15:45

Refs #21660: Flow controller example

cb4cf67

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

Refs #21660: RTPS example

2ebc1c7

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

Refs #21660: Custom PayloadPool example

2596912

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

Refs #21660: Additional cmake vars for configuring extra arguments lists

f8e35e2

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

Mario-DL added this to the v3.2.0 milestone Dec 10, 2024

Mario-DL added 2 commits December 10, 2024 17:04

Refs #21660: Content Filter example

5259cd1

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

Refs #21660: Add examples to CMakeLists.txt

3f9aa32

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

Mario-DL force-pushed the examples/21660 branch from 49e2d1b to 3f9aa32 Compare December 10, 2024 16:04

Mario-DL requested review from richiprosima and removed request for richiprosima December 10, 2024 16:05

github-actions bot added the ci-pending PR which CI is running label Dec 10, 2024

rsanchez15 approved these changes Dec 13, 2024

View reviewed changes

rsanchez15 merged commit 0deeb14 into master Dec 13, 2024
17 checks passed

rsanchez15 deleted the examples/21660 branch December 13, 2024 08:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[21660] Add `flow_control`, `rtps`, `custom_payload_pool` and `content_filter` to windows example ci testing #5480

[21660] Add `flow_control`, `rtps`, `custom_payload_pool` and `content_filter` to windows example ci testing #5480

Mario-DL commented Dec 10, 2024 •

edited by rsanchez15

Loading

Mario-DL commented Dec 13, 2024

mergify bot commented Dec 13, 2024 •

edited

Loading

[21660] Add flow_control, rtps, custom_payload_pool and content_filter to windows example ci testing #5480

[21660] Add flow_control, rtps, custom_payload_pool and content_filter to windows example ci testing #5480

Conversation

Mario-DL commented Dec 10, 2024 • edited by rsanchez15 Loading

Description

Contributor Checklist

Reviewer Checklist

Mario-DL commented Dec 13, 2024

mergify bot commented Dec 13, 2024 • edited Loading

✅ Backports have been created

[21660] Add `flow_control`, `rtps`, `custom_payload_pool` and `content_filter` to windows example ci testing #5480

[21660] Add `flow_control`, `rtps`, `custom_payload_pool` and `content_filter` to windows example ci testing #5480

Mario-DL commented Dec 10, 2024 •

edited by rsanchez15

Loading

mergify bot commented Dec 13, 2024 •

edited

Loading