Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19780] Add interface whitelist by name #3973

Merged
merged 22 commits into from
Dec 5, 2023
Merged

[19780] Add interface whitelist by name #3973

merged 22 commits into from
Dec 5, 2023

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Oct 31, 2023 •
edited by juanlofer-eprosima
Loading

Description

The feature gives users the possibility to add network interfaces to the whitelist by interface name as well, not just by their IP address.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
    Related documentation PR: [19780] Add interface whitelist by name Fast-DDS-docs#591
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf marked this pull request as draft October 31, 2023 08:06
@elianalf elianalf added this to the v2.13.0 milestone Oct 31, 2023
@elianalf elianalf added doc-pending Issue or PR which is pending to be documented ci-pending PR which CI is running labels Oct 31, 2023
@elianalf elianalf force-pushed the feature/19780 branch 2 times, most recently from c80187f to c25dda8 Compare November 2, 2023 09:13
juanlofer-eprosima
juanlofer-eprosima requested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done rookie 🥇

@elianalf elianalf changed the title Refs #19780: Add the possibility to whitelist interfaces defining the… [19780] Whitelist interfaces added by name Nov 2, 2023
@elianalf elianalf changed the title [19780] Whitelist interfaces added by name [19780] Add interface whitelist by name Nov 2, 2023
@elianalf elianalf requested a review from EduPonz November 2, 2023 14:25
EduPonz
EduPonz suggested changes Nov 3, 2023
View reviewed changes
@elianalf elianalf requested a review from EduPonz November 3, 2023 09:44
juanlofer-eprosima
juanlofer-eprosima requested changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update versions.md and rebase. Also, please have a look at failing test UDPv6Tests.send_to_allowed_interface .

juanlofer-eprosima
juanlofer-eprosima requested changes Nov 7, 2023
View reviewed changes
@elianalf elianalf marked this pull request as ready for review November 7, 2023 13:04
@elianalf elianalf removed the doc-pending Issue or PR which is pending to be documented label Nov 7, 2023
@elianalf
Copy link
Contributor Author

elianalf commented Nov 8, 2023

@richiprosima Please test this

@juanlofer-eprosima juanlofer-eprosima mentioned this pull request Nov 8, 2023
Merged
EduPonz
EduPonz suggested changes Nov 9, 2023
View reviewed changes
@elianalf elianalf requested a review from EduPonz November 10, 2023 08:31
EduPonz
EduPonz previously approved these changes Nov 10, 2023
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@elianalf
Copy link
Contributor Author

@richiprosima Please test this

@EduPonz
Copy link

EduPonz commented Nov 13, 2023

@richiprosima please test windows test mac

@elianalf @EduPonz
Refs #19780: Apply suggestions
5c82b6a 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf @EduPonz
Refs #19780: Please linter
39f317e 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf @EduPonz
Refs #19780: Add 'interface_name'
8c812b4 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf @EduPonz
Refs #19780: Fix 'interface_name' definition in xsd file
62f439c 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf @EduPonz
Refs #19780: Apply suggestions
36ce2c8 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf @EduPonz
Refs #19780: Uncrustify
1e441b9 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf @EduPonz
Refs #19780: Aplly suggestions
945d562 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf @EduPonz
Refs 19780: Apply suggestions
7c28822 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf @EduPonz
Refs #19780: Update versions file and apply suggestions
7911036 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf @EduPonz
Refs #19780: Update comment in test
db78b0c 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf @EduPonz
Refs #19780: Update tests to test all different cases
9257a8c 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf @EduPonz
Refs #19780: Apply suggestion about a test
e822ffe 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #19780: Fix failed tests
9bb8de0 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
EduPonz
EduPonz suggested changes Nov 24, 2023
View reviewed changes
@elianalf
Refs #19780: Apply suggestion
99b8d11 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Copy link
Contributor Author

@richiprosima please test this

EduPonz
EduPonz previously approved these changes Nov 27, 2023
View reviewed changes
@EduPonz
Copy link

EduPonz commented Nov 27, 2023

@richiprosima please test mac

1 similar comment
@EduPonz
Copy link

EduPonz commented Nov 27, 2023

@richiprosima please test mac

@elianalf
Copy link
Contributor Author

@richiprosima Please test discovery-server, and also test mac

@elianalf
Refs #19780: Rename a local variable
497c89a 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Copy link
Contributor Author

@richiprosima please test this

@juanlofer-eprosima
Copy link
Contributor

@richiprosima please test mac

@elianalf
Copy link
Contributor Author

elianalf commented Dec 5, 2023

@richiprosima please test mac

@EduPonz EduPonz merged commit 5184f31 into master Dec 5, 2023
@EduPonz EduPonz deleted the feature/19780 branch December 5, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

@juanlofer-eprosima juanlofer-eprosima Awaiting requested review from juanlofer-eprosima

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@elianalf @EduPonz @juanlofer-eprosima