Compile error when building fastdds 2.5.0 with foonathan_memory 0.7-1 using GCC 5.5 [13720]

[Nir-Az]

Hi,

When building fastdds 2.5.0 with foonathan_memory 0.7-1 on GNU 5.5.0 I am getting a compilation error,

any reason why?

When compiling with GNU 7.5 it works.
AFAIK GCC 5.5 support C++11.

@MiguelCompany looks like this change was introduced a month ago see PR #2359

As I see the problem is with this line :

Fast-DDS/src/cpp/fastdds/domain/DomainParticipantImpl.cpp

Line 543 in 6d569ad

filtered_topics_.emplace(std::make_pair(name, topic));

Thanks

2022-01-31T15:55:22.8306864Z In file included from /usr/include/x86_64-linux-gnu/c++/5/bits/c++allocator.h:33:0,
2022-01-31T15:55:22.8307214Z                  from /usr/include/c++/5/bits/allocator.h:46,
2022-01-31T15:55:22.8307453Z                  from /usr/include/c++/5/string:41,
2022-01-31T15:55:22.8307733Z                  from /usr/include/c++/5/bits/locale_classes.h:40,
2022-01-31T15:55:22.8308177Z                  from /usr/include/c++/5/bits/ios_base.h:41,
2022-01-31T15:55:22.8308415Z                  from /usr/include/c++/5/ios:42,
2022-01-31T15:55:22.8308657Z                  from /usr/include/c++/5/ostream:38,
2022-01-31T15:55:22.8308883Z                  from /usr/include/c++/5/iostream:39,
2022-01-31T15:55:22.8309409Z                  from /home/runner/work/librealsense/librealsense/build/third-party/fastdds/include/fastdds/rtps/common/Types.h:23,
2022-01-31T15:55:22.8309974Z                  from /home/runner/work/librealsense/librealsense/build/third-party/fastdds/include/fastdds/rtps/common/Guid.h:23,
2022-01-31T15:55:22.8310852Z                  from /home/runner/work/librealsense/librealsense/build/third-party/fastdds/src/cpp/fastdds/domain/DomainParticipantImpl.hpp:23,
2022-01-31T15:55:22.8311617Z                  from /home/runner/work/librealsense/librealsense/build/third-party/fastdds/src/cpp/fastdds/domain/DomainParticipantImpl.cpp:20:
2022-01-31T15:55:22.8313375Z /usr/include/c++/5/ext/new_allocator.h: In instantiation of ‘void __gnu_cxx::new_allocator<_Tp>::construct(_Up*, _Args&& ...) [with _Up = std::pair<const std::__cxx11::basic_string<char>, std::unique_ptr<eprosima::fastdds::dds::ContentFilteredTopic> >; _Args = {std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, eprosima::fastdds::dds::ContentFilteredTopic*>}; _Tp = std::_Rb_tree_node<std::pair<const std::__cxx11::basic_string<char>, std::unique_ptr<eprosima::fastdds::dds::ContentFilteredTopic> > >]’:
2022-01-31T15:55:22.8316282Z /usr/include/c++/5/bits/alloc_traits.h:530:4:   required from ‘static void std::allocator_traits<std::allocator<_CharT> >::construct(std::allocator_traits<std::allocator<_CharT> >::allocator_type&, _Up*, _Args&& ...) [with _Up = std::pair<const std::__cxx11::basic_string<char>, std::unique_ptr<eprosima::fastdds::dds::ContentFilteredTopic> >; _Args = {std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, eprosima::fastdds::dds::ContentFilteredTopic*>}; _Tp = std::_Rb_tree_node<std::pair<const std::__cxx11::basic_string<char>, std::unique_ptr<eprosima::fastdds::dds::ContentFilteredTopic> > >; std::allocator_traits<std::allocator<_CharT> >::allocator_type = std::allocator<std::_Rb_tree_node<std::pair<const std::__cxx11::basic_string<char>, std::unique_ptr<eprosima::fastdds::dds::ContentFilteredTopic> > > >]’
2022-01-31T15:55:22.8319274Z /usr/include/c++/5/bits/stl_tree.h:529:32:   required from ‘void std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_M_construct_node(std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_Link_type, _Args&& ...) [with _Args = {std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, eprosima::fastdds::dds::ContentFilteredTopic*>}; _Key = std::__cxx11::basic_string<char>; _Val = std::pair<const std::__cxx11::basic_string<char>, std::unique_ptr<eprosima::fastdds::dds::ContentFilteredTopic> >; _KeyOfValue = std::_Select1st<std::pair<const std::__cxx11::basic_string<char>, std::unique_ptr<eprosima::fastdds::dds::ContentFilteredTopic> > >; _Compare = std::less<std::__cxx11::basic_string<char> >; _Alloc = std::allocator<std::pair<const std::__cxx11::basic_string<char>, std::unique_ptr<eprosima::fastdds::dds::ContentFilteredTopic> > >; std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_Link_type = std::_Rb_tree_node<std::pair<const std::__cxx11::basic_string<char>, std::unique_ptr<eprosima::fastdds::dds::ContentFilteredTopic> > >*]’
2022-01-31T15:55:22.8322468Z /usr/include/c++/5/bits/stl_tree.h:546:21:   required from ‘std::_Rb_tree_node<_Val>* std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_M_create_node(_Args&& ...) [with _Args = {std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, eprosima::fastdds::dds::ContentFilteredTopic*>}; _Key = std::__cxx11::basic_string<char>; _Val = std::pair<const std::__cxx11::basic_string<char>, std::unique_ptr<eprosima::fastdds::dds::ContentFilteredTopic> >; _KeyOfValue = std::_Select1st<std::pair<const std::__cxx11::basic_string<char>, std::unique_ptr<eprosima::fastdds::dds::ContentFilteredTopic> > >; _Compare = std::less<std::__cxx11::basic_string<char> >; _Alloc = std::allocator<std::pair<const std::__cxx11::basic_string<char>, std::unique_ptr<eprosima::fastdds::dds::ContentFilteredTopic> > >; std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_Link_type = std::_Rb_tree_node<std::pair<const std::__cxx11::basic_string<char>, std::unique_ptr<eprosima::fastdds::dds::ContentFilteredTopic> > >*]’
2022-01-31T15:55:22.8325121Z /usr/include/c++/5/bits/stl_tree.h:2152:33:   required from ‘std::pair<std::_Rb_tree_iterator<_Val>, bool> std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_M_emplace_unique(_Args&& ...) [with _Args = {std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, eprosima::fastdds::dds::ContentFilteredTopic*>}; _Key = std::__cxx11::basic_string<char>; _Val = std::pair<const std::__cxx11::basic_string<char>, std::unique_ptr<eprosima::fastdds::dds::ContentFilteredTopic> >; _KeyOfValue = std::_Select1st<std::pair<const std::__cxx11::basic_string<char>, std::unique_ptr<eprosima::fastdds::dds::ContentFilteredTopic> > >; _Compare = std::less<std::__cxx11::basic_string<char> >; _Alloc = std::allocator<std::pair<const std::__cxx11::basic_string<char>, std::unique_ptr<eprosima::fastdds::dds::ContentFilteredTopic> > >]’
2022-01-31T15:55:22.8327949Z /usr/include/c++/5/bits/stl_map.h:560:64:   required from ‘std::pair<typename std::_Rb_tree<_Key, std::pair<const _Key, _Tp>, std::_Select1st<std::pair<const _Key, _Tp> >, _Compare, typename __gnu_cxx::__alloc_traits<_Allocator>::rebind<std::pair<const _Key, _Tp> >::other>::iterator, bool> std::map<_Key, _Tp, _Compare, _Alloc>::emplace(_Args&& ...) [with _Args = {std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, eprosima::fastdds::dds::ContentFilteredTopic*>}; _Key = std::__cxx11::basic_string<char>; _Tp = std::unique_ptr<eprosima::fastdds::dds::ContentFilteredTopic>; _Compare = std::less<std::__cxx11::basic_string<char> >; _Alloc = std::allocator<std::pair<const std::__cxx11::basic_string<char>, std::unique_ptr<eprosima::fastdds::dds::ContentFilteredTopic> > >; typename std::_Rb_tree<_Key, std::pair<const _Key, _Tp>, std::_Select1st<std::pair<const _Key, _Tp> >, _Compare, typename __gnu_cxx::__alloc_traits<_Allocator>::rebind<std::pair<const _Key, _Tp> >::other>::iterator = std::_Rb_tree_iterator<std::pair<const std::__cxx11::basic_string<char>, std::unique_ptr<eprosima::fastdds::dds::ContentFilteredTopic> > >]’
2022-01-31T15:55:22.8329731Z /home/runner/work/librealsense/librealsense/build/third-party/fastdds/src/cpp/fastdds/domain/DomainParticipantImpl.cpp:543:57:   required from here
2022-01-31T15:55:22.8330636Z /usr/include/c++/5/ext/new_allocator.h:120:4: error: no matching function for call to ‘std::pair<const std::__cxx11::basic_string<char>, std::unique_ptr<eprosima::fastdds::dds::ContentFilteredTopic> >::pair(std::pair<std::__cxx11::basic_string<char>, eprosima::fastdds::dds::ContentFilteredTopic*>)’
2022-01-31T15:55:22.8331239Z   { ::new((void *)__p) _Up(std::forward<_Args>(__args)...); }```

[Nir-Az]

I can see on FastDDS Cmake thane the minimal MSVC version supported is 19,
How about GCC?
Should FastDDS support GCC 5.5?
Thanks.

[JLBuenoLopez]

Hi @Nir-Az,

The std::make_pair issue you mention is going to be fixed in a PR soon. However, the official support right now is for Ubuntu Focal (20.04) which by default installs GCC 9. Consequently this is the current official support for GCC. This is made explicit in #2472. This means that GCC 5 is not tested in our CI and could be broken at any time again in the future. If you want to include official support for a specific compiler, you can always contact our support team.

[Nir-Az]

Thanks, missed the platform support file.

[chenzhengxi]

Old bug since 2.4.0

[JLBuenoLopez]

@Nir-Az,

Would you mind checking if the issue is still happening in Fast DDS 2.5.1? A fix was introduced in that release.

[Nir-Az]

Sure thing, thanks for the fix.
I will update as soon as I integrate the new release.

[Nir-Az]

@JLBuenoLopez-eProsima , @MiguelCompany ,

So I updated my project to use FastDDS 2.5.1 and sadly the compile error is still with us , but from a different file? not sure.
take a look:
Gcc 5 Error.txt

error: use of deleted function ‘constexpr std::pair<_T1, _T2>::pair(const std::pair<_T1, _T2>&) [with _T1 = const std::__cxx11::basic_string<char>; _T2 = std::unique_ptr<eprosima::fastdds::rtps::FlowController>]’

 error: use of deleted function ‘std::unique_ptr<_Tp, _Dp>::unique_ptr(const std::unique_ptr<_Tp, _Dp>&) [with _Tp = eprosima::fastdds::rtps::FlowController; _Dp = std::default_delete<eprosima::fastdds::rtps::FlowController>]’

[JLBuenoLopez]

Hi @Nir-Az,

As I said in a previous comment, GCC 5 is not included in our official support so compilation may break at any time. I suggest either upgrading your GCC if possible or contacting our support team to get official support.

Also, according to our recently updated CONTRIBUTING guidelines I am going to move this issue to the Unofficial Support discussion forum.

[Nir-Az]

👍

[EduPonz]

Hi everyone, I just want to bring #3034 to your attention. I think it should fix your GCC 5.5 builds. Nonetheless, I'd suggest trying to upgrade GCC, as we do not official support 5.5 so it is doomed to stop working again at some point.