Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22705] Fix counters and change endpoint names in problems view #245

Merged
merged 5 commits into from
Jan 30, 2025

Conversation

Carlosespicur
Copy link
Contributor

@Carlosespicur Carlosespicur commented Jan 20, 2025

Main changes

This PR fixes a bug in warning counters caused by the refactor of the problems view. Total warnings counter is not displayed correctly (it shows the same number as error counter).
It also adds an endpoint kind prefix to endpoint names.

It must be merged after:

Copy link
Collaborator

@rsanchez15 rsanchez15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the "remote entity" be the name of the entity in the database instead of just the full GUID?

src/Engine.cpp Outdated Show resolved Hide resolved
@rsanchez15 rsanchez15 changed the title Fix counters and change endpoint names in problems view [22705] Fix counters and change endpoint names in problems view Jan 27, 2025
Carlosespicur and others added 4 commits January 29, 2025 15:05
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15 rsanchez15 force-pushed the hotfix/problem-counters branch from b30ea7d to 356cca1 Compare January 29, 2025 14:06
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
Copy link
Contributor Author

@Carlosespicur Carlosespicur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsanchez15 rsanchez15 merged commit 0fed95d into main Jan 30, 2025
14 checks passed
@rsanchez15 rsanchez15 deleted the hotfix/problem-counters branch January 30, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants