Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default ros2 publication mode #1025

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Fix default ros2 publication mode #1025

merged 2 commits into from
Jan 31, 2025

Conversation

rsanchez15
Copy link
Contributor

@rsanchez15 rsanchez15 commented Jan 31, 2025 •
edited by MiguelCompany
Loading

Description

This PR address this issue: ros2/rmw_fastrtps#804

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@rsanchez15
Fix default ros2 publication mode
2a7c616 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@MiguelCompany MiguelCompany added this to the v3.2.0 milestone Jan 31, 2025
MiguelCompany
MiguelCompany requested changes Jan 31, 2025
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to change line 27

@rsanchez15
Update missed reference
4d36525 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15 rsanchez15 requested review from MiguelCompany and removed request for MiguelCompany January 31, 2025 07:03
@MiguelCompany MiguelCompany merged commit b7909d6 into master Jan 31, 2025
4 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/sync-pub-ros branch January 31, 2025 07:57
@MiguelCompany
Copy link
Member

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

@mergify Mergify
Copy link

mergify bot commented Jan 31, 2025 •
edited
Loading

backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 31, 2025
@rsanchez15 @mergify
Fix default ros2 publication mode (#1025)
b9316a9 
* Fix default ros2 publication mode

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Update missed reference

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit b7909d6)
@mergify mergify bot mentioned this pull request Jan 31, 2025
Merged
7 tasks
mergify bot pushed a commit that referenced this pull request Jan 31, 2025
@rsanchez15 @mergify
Fix default ros2 publication mode (#1025)
4839339 
* Fix default ros2 publication mode

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Update missed reference

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit b7909d6)
mergify bot pushed a commit that referenced this pull request Jan 31, 2025
@rsanchez15 @mergify
Fix default ros2 publication mode (#1025)
55526c9 
* Fix default ros2 publication mode

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Update missed reference

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit b7909d6)
@MiguelCompany MiguelCompany mentioned this pull request Jan 31, 2025
Closed
This was referenced Jan 31, 2025
Merged
Merged
mergify bot pushed a commit that referenced this pull request Jan 31, 2025
@rsanchez15 @mergify
Fix default ros2 publication mode (#1025)
f59f900 
* Fix default ros2 publication mode

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Update missed reference

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit b7909d6)
@mergify mergify bot mentioned this pull request Jan 31, 2025
Merged
7 tasks
mergify bot pushed a commit that referenced this pull request Jan 31, 2025
@rsanchez15 @mergify
Fix default ros2 publication mode (#1025)
db087c3 
* Fix default ros2 publication mode

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Update missed reference

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit b7909d6)
@mergify mergify bot mentioned this pull request Jan 31, 2025
Merged
7 tasks
MiguelCompany pushed a commit that referenced this pull request Jan 31, 2025
@mergify @rsanchez15
Fix default ros2 publication mode (#1025) (#1026)
fce2cec 
* Fix default ros2 publication mode

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Update missed reference

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit b7909d6)

Co-authored-by: Raul Sanchez-Mateos Lizano <raul@eprosima.com>
MiguelCompany pushed a commit that referenced this pull request Jan 31, 2025
@mergify @rsanchez15
Fix default ros2 publication mode (#1025) (#1027)
494dce2 
* Fix default ros2 publication mode

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Update missed reference

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit b7909d6)

Co-authored-by: Raul Sanchez-Mateos Lizano <raul@eprosima.com>
MiguelCompany pushed a commit that referenced this pull request Jan 31, 2025
@mergify @rsanchez15
Fix default ros2 publication mode (#1025) (#1028)
a0ad9fb 
* Fix default ros2 publication mode

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Update missed reference

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit b7909d6)

Co-authored-by: Raul Sanchez-Mateos Lizano <raul@eprosima.com>
MiguelCompany pushed a commit that referenced this pull request Jan 31, 2025
@mergify @rsanchez15
Fix default ros2 publication mode (#1025) (#1029)
cf7f9ef 
* Fix default ros2 publication mode

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Update missed reference

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit b7909d6)

Co-authored-by: Raul Sanchez-Mateos Lizano <raul@eprosima.com>
MiguelCompany pushed a commit that referenced this pull request Jan 31, 2025
@mergify @rsanchez15
Fix default ros2 publication mode (#1025) (#1030)
0cbfeca 
* Fix default ros2 publication mode

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Update missed reference

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit b7909d6)

Co-authored-by: Raul Sanchez-Mateos Lizano <raul@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rsanchez15 @MiguelCompany @cferreiragonz