Don't check subscribers' max-time when verifying the max-tx-rate in tests #419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version, the manual topics's tests configured participants with different max-tx-rates and then verified that the subscribers didn't take less than
--min-time
(ensuring that the publication frequency got capped) or more than--max-time
. At times, however, the publisher would take too long to match the DDS Router and the--max-time
would be missed. Ideally, we would measure the time when the subscriber received the first message, but since the subscriber runs in a subprocess and its output is only processed when the subscriber exits, we can't. Therefore, to fix the error, we will bypass the verification of--max-time
as it is irrelevant when only configuring the max-tx-rate.