Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check subscribers' max-time when verifying the max-tx-rate in tests #419

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

Tempate
Copy link
Contributor

@Tempate Tempate commented Jan 2, 2024

In the previous version, the manual topics's tests configured participants with different max-tx-rates and then verified that the subscribers didn't take less than --min-time (ensuring that the publication frequency got capped) or more than --max-time. At times, however, the publisher would take too long to match the DDS Router and the --max-time would be missed. Ideally, we would measure the time when the subscriber received the first message, but since the subscriber runs in a subprocess and its output is only processed when the subscriber exits, we can't. Therefore, to fix the error, we will bypass the verification of --max-time as it is irrelevant when only configuring the max-tx-rate.

Signed-off-by: tempate <danieldiaz@eprosima.com>
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ec8299) 31.45% compared to head (90182e7) 31.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #419   +/-   ##
=======================================
  Coverage   31.45%   31.45%           
=======================================
  Files          15       15           
  Lines         531      531           
  Branches      274      274           
=======================================
  Hits          167      167           
  Misses        191      191           
  Partials      173      173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rsanchez15 rsanchez15 merged commit cd3d7ef into main Jan 2, 2024
18 of 21 checks passed
@rsanchez15 rsanchez15 deleted the hotfix/slow_manual_topics_tests branch January 2, 2024 11:34
Tempate added a commit that referenced this pull request Mar 8, 2024
Signed-off-by: tempate <danieldiaz@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants