Create all tracks on built-in topics #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
=======================================
Coverage 31.45% 31.45%
=======================================
Files 15 15
Lines 531 531
Branches 274 274
=======================================
Hits 167 167
Misses 191 191
Partials 173 173 ☔ View full report in Codecov by Sentry. |
Tempate
changed the title
irenebm
suggested changes
Dec 18, 2023
Tempate
force-pushed
the
feature/dynamic_tracks_builtin_topics
branch
from
bc79e8d to
e1bd55b
Compare
Tempate
force-pushed
the
feature/dynamic_tracks_builtin_topics
branch
from
e1bd55b to
3a30f3a
Compare
Tempate
force-pushed
the
feature/dynamic_tracks_builtin_topics
branch
from
3a30f3a to
996d0b6
Compare
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
Tempate
force-pushed
the
feature/dynamic_tracks_builtin_topics
branch
from
996d0b6 to
1167fc7
Compare
rsanchez15
approved these changes
Dec 22, 2023
Tempate
added a commit
that referenced
this pull request
Mar 8, 2024
* Update the configuration Signed-off-by: tempate <danieldiaz@eprosima.com> * Apply suggestions Signed-off-by: tempate <danieldiaz@eprosima.com> --------- Signed-off-by: tempate <danieldiaz@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version, built-in topics were incompatible with
remove-unused-entities. Now,remove-unused-entitiesonly applies to topics that are discovered (i.e. topics that aren't built-in).Merge after: