Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application properties to participants [19865] #408

Merged
merged 5 commits into from
Nov 28, 2023

Conversation

irenebm
Copy link
Contributor

@irenebm irenebm commented Nov 23, 2023

No description provided.

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5988fa4) 31.56% compared to head (f4b96a8) 31.45%.

Files Patch % Lines
ddsrouter_core/src/cpp/core/ParticipantFactory.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   31.56%   31.45%   -0.12%     
==========================================
  Files          15       15              
  Lines         529      531       +2     
  Branches      272      274       +2     
==========================================
  Hits          167      167              
  Misses        191      191              
- Partials      171      173       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@irenebm irenebm changed the title Add application properties to participants Add application properties to participants [19865] Nov 24, 2023
@irenebm irenebm force-pushed the feature/app_id_metadata branch from bb56dfd to f20eca8 Compare November 24, 2023 09:39
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm irenebm marked this pull request as ready for review November 28, 2023 07:34
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irenebm irenebm merged commit c6e6ef4 into main Nov 28, 2023
18 of 20 checks passed
@irenebm irenebm deleted the feature/app_id_metadata branch November 28, 2023 07:59
Tempate pushed a commit that referenced this pull request Mar 8, 2024
* Add app_id and app_metadata properties

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

* Add participant factory tests

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

* Change dynamic_pointer_cast to static_pointer_cast

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

* Add tetss to XTSAN.list

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

* Test documentation in ParticipantFactoryTest

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

---------

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants