-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add application properties to participants [19865] #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
597d11a
to
4beaa14
Compare
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
4beaa14
to
dc71866
Compare
0c0fc15
to
bb56dfd
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #408 +/- ##
==========================================
- Coverage 31.56% 31.45% -0.12%
==========================================
Files 15 15
Lines 529 531 +2
Branches 272 274 +2
==========================================
Hits 167 167
Misses 191 191
- Partials 171 173 +2 ☔ View full report in Codecov by Sentry. |
bb56dfd
to
f20eca8
Compare
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
f20eca8
to
d68ab60
Compare
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
juanlofer-eprosima
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tempate
pushed a commit
that referenced
this pull request
Mar 8, 2024
* Add app_id and app_metadata properties Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Add participant factory tests Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Change dynamic_pointer_cast to static_pointer_cast Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Add tetss to XTSAN.list Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Test documentation in ParticipantFactoryTest Signed-off-by: Irene Bandera <irenebandera@eprosima.com> --------- Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.