Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.2.0 beta.1 SDK #626

Merged
merged 223 commits into from
Apr 2, 2025
Merged

Release 1.2.0 beta.1 SDK #626

merged 223 commits into from
Apr 2, 2025

Conversation

0div
Copy link
Contributor

@0div 0div commented Mar 21, 2025 •
edited
Loading

0div and others added 30 commits October 4, 2024 19:58
@0div
Added multi-file write support
b2e80e1
@0div
address PR comments
9e6bc17
@ValentaTomas
[WIP] Cleanup
966f0c7
@0div
address PR comments
eda88d0
@0div
boyscouting: fix some docstrings
a2d4ad7
@0div
Add multi-file write support for python-sdk sync
a379a58
@0div
Use @overload
608ef45
@0div
merge beta
68ac038
@0div
adapt multi file write tests for nested dirs
f010211
@0div
allow passing empty array of files in python-sdk
fbc4af4
@0div
allow passing empty array of files in js-sdk
2afb6d1
@0div
address PR comments
68e5efa
@0div
add extra tests to sandbox_sync write
365af43
@0div
updated js-sdk tests to check empty path behavior
7767d8f
@0div
add multifile upload to sanbox_async
f5cd1c0
@0div
merge beta
834f84c
@0div
better error messages in python-sdk
2956a6e
@0div
better error messages in js-sdk
c277f9f
@0div
docstring for dataclass
86262f1
@0div
merge main
97d0cc1
@0div
fix errors.ts comment
cf262ae
@0div
fixed typing syntax and watch tests
4ca2414
@0div
update docs
93dc1f9
@0div
add minor changeset
741b329
@0div
upadte upload docs and improve read-write-docs
bbeeb04
@0div
fix indentation in upload docs
0e2a684
@0div @mlejva
Update apps/web/src/app/(docs)/docs/filesystem/read-write/page.mdx
b867fe4 
Co-authored-by: Vasek Mlejnsky <vasek@e2b.dev>
@0div @mlejva
Update apps/web/src/app/(docs)/docs/filesystem/read-write/page.mdx
e730810 
Co-authored-by: Vasek Mlejnsky <vasek@e2b.dev>
@0div @mlejva
Update apps/web/src/app/(docs)/docs/filesystem/upload/page.mdx
d3b99fe 
Co-authored-by: Vasek Mlejnsky <vasek@e2b.dev>
@0div @mlejva
Update apps/web/src/app/(docs)/docs/filesystem/upload/page.mdx
424baec 
Co-authored-by: Vasek Mlejnsky <vasek@e2b.dev>
@ValentaTomas ValentaTomas requested review from sitole and removed request for mlejva, jakubno and ben-fornefeld March 23, 2025 18:21
@sitole
Copy link
Member

sitole commented Mar 24, 2025

@0div can you rebase it to make here only your changes?

@ValentaTomas
Copy link
Member

The branch is pretty messy, so I don't think this is simple to do.
We should in the future rebase from the start.

@0div
Copy link
Contributor Author

0div commented Mar 27, 2025

@ValentaTomas, is there a specific cluster against which i can re-test this that has comprehensive beta features?

@0div 0div changed the title Add multi-file upload and less flaky metrics test for 1.2.0 beta.1 release Release 1.2.0 beta.1 SDK Mar 27, 2025
@ValentaTomas
Copy link
Member

@ValentaTomas, is there a specific cluster against which i can re-test this that has comprehensive beta features?

It should be foxtrot right now (and in the future staging).

@ValentaTomas
Copy link
Member

@mishushakov Please review, resolve and merge when ready.
From now on then we should rebase to the beta branch from main to keep the git history clean.

@mishushakov
Copy link
Member

@0div can you update the description? Is this basically a merge main <> beta?

@0div
Copy link
Contributor Author

0div commented Mar 30, 2025 •
edited
Loading

@0div can you update the description? Is this basically a merge main <> beta?

@mishushakov yes, it is essentially a merge of main (a week+ old version of it now) into beta. The description is ment to highlight what features in particular are being added to this release in particular and why.

@mishushakov
Copy link
Member

@0div did you run the tests locally? Besides that, looks good so far, also make sure OpenAPI spec is merged properly and clients are generated

@0div
Copy link
Contributor Author

0div commented Mar 31, 2025

@0div did you run the tests locally? Besides that, looks good so far, also make sure OpenAPI spec is merged properly and clients are generated

@mishushakov tested against foxtrot, made some adjustments, pls take another look

mishushakov
mishushakov approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@mishushakov mishushakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is safe to merge - please verify also that the the SDKs build locally

@0div
Copy link
Contributor Author

0div commented Apr 2, 2025

  • js-sdk/ pnpm build ✅
  • python-sdk/ poetry build ✅
  • cli/ pnpm build ✅

@mishushakov
Copy link
Member

Okay, I think you're good to go 👍

@0div 0div merged commit 5ee025c into beta Apr 2, 2025
2 checks passed
@0div 0div deleted the add-multifile-and-less-1.2.0-beta.1-release branch April 2, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishushakov mishushakov mishushakov approved these changes

@ValentaTomas ValentaTomas Awaiting requested review from ValentaTomas ValentaTomas is a code owner

@sitole sitole Awaiting requested review from sitole

Assignees

@0div 0div

Labels
sdk-beta Released in the Beta SDKs version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.