Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MachRegister type query tests #9

Closed
wants to merge 9 commits into from

Conversation

hainest
Copy link
Collaborator

@hainest hainest commented Dec 30, 2024

@bbiiggppiigg No register for all three amdgpu architectures seem to be flags (according to isFlag).

@hainest hainest self-assigned this Dec 30, 2024
@hainest hainest force-pushed the thaines/machregister_type_queries branch from 0140630 to a48ff83 Compare December 30, 2024 14:44
@bbiiggppiigg
Copy link

@bbiiggppiigg No register for all three amdgpu architectures seem to be flags (according to isFlag).

I know some of the registers should be flag but are defined as HWR for now.
I should probably clean up the register definitions a bit. (And maybe how getBaseRegister is done for AMDGPU)
If this is not blocking any changes you're doing, I think I should wait until you are done with all your MachRegister changes.

@hainest
Copy link
Collaborator Author

hainest commented Dec 30, 2024

@bbiiggppiigg No register for all three amdgpu architectures seem to be flags (according to isFlag).

I know some of the registers should be flag but are defined as HWR for now. I should probably clean up the register definitions a bit. (And maybe how getBaseRegister is done for AMDGPU) If this is not blocking any changes you're doing, I think I should wait until you are done with all your MachRegister changes.

Nope, it's not blocking me. I just wanted to make sure I had covered all the cases.

@hainest hainest force-pushed the thaines/machregister_type_queries branch from 0316664 to 969d0b0 Compare January 12, 2025 15:47
@hainest
Copy link
Collaborator Author

hainest commented Jan 29, 2025

Moved to dyninst/dyninst#1855.

@hainest hainest closed this Jan 29, 2025
@hainest hainest deleted the thaines/machregister_type_queries branch January 29, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants