Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ppc base register tests #12

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Add ppc base register tests #12

merged 2 commits into from
Jan 15, 2025

Conversation

hainest
Copy link
Collaborator

@hainest hainest commented Jan 12, 2025 •
edited
Loading

@hainest hainest self-assigned this Jan 12, 2025
@hainest hainest mentioned this pull request Jan 12, 2025
Merged
@hainest hainest requested a review from kupsch January 12, 2025 16:17
@hainest hainest marked this pull request as ready for review January 12, 2025 16:17
kupsch
kupsch reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@kupsch kupsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do r<N>, fpr<N>, and vsr<N> map to their respective 0 register? Shouldn't they map to themselves.

What are fsr<N>? I'm having problems find any information about them.

@wrwilliams
Copy link
Member

Why do r<N>, fpr<N>, and vsr<N> map to their respective 0 register? Shouldn't they map to themselves.

What are fsr<N>? I'm having problems find any information about them.

IIRC those were the single-precision FPR aliases but I may not recall correctly.

@kupsch
Copy link
Contributor

kupsch commented Jan 13, 2025

Thanks Bill. Then the base register of the fsr<N> should be fpr<N> as the value is stored in the same register.

@hainest hainest force-pushed the thaines/ppc32_basereg branch from 6613cc3 to 8d9361b Compare January 14, 2025 18:36
@hainest hainest merged commit ff43d80 into main Jan 15, 2025
3 of 7 checks passed
@hainest hainest deleted the thaines/ppc32_basereg branch January 15, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kupsch kupsch kupsch approved these changes

Assignees

@hainest hainest

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hainest @wrwilliams @kupsch