BLD: Fix broken versions #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arviz uses scipy.signal.gaussian, which was removed in 1.13. Most recent arviz uses scipy.signal.windows.gaussian scikit-learn 1.5.0 contained a regression (scikit-learn/scikit-learn#28352) that has been fixed in scikit-learn/scikit-learn#29078
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #512 +/- ##
=======================================
Coverage 94.70% 94.70%
=======================================
Files 38 38
Lines 4114 4114
=======================================
Hits 3896 3896
Misses 218 218 ☔ View full report in Codecov by Sentry. |
To test the notebooks, need to install SBR extras, which included a version of arviz that isn't available on 3.9. Earlier version works, but restricts scipy version
Jacob-Stevens-Haas
force-pushed
the
hotfix-sklearn-scipy
branch
from
2619624 to
3cc261a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arviz uses scipy.signal.gaussian, which was removed in 1.13. Most recent arviz uses scipy.signal.windows.gaussian
scikit-learn 1.5.0 contained a regression
(scikit-learn/scikit-learn#28352) that has been fixed in
scikit-learn/scikit-learn#29078