-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert both ways. #5
Comments
I would agree... |
Great point! When I built this it seemed like a much easier undertaking than parsing XML. I'm happy to accept review and accept PR for converting arbitrary XML to this project's JSON format. |
The less ideal solution is to use 2 libs: xml for json to xml and https://github.com/Leonidas-from-XIV/node-xml2js for xml to json converting. |
@dylang Is there any work put into this? This library is a lot more compelling to use than |
I'm not planning on creating an xml parser. I think it would be best to use separate package that's already good that doing that because of the complexity, but I'm happy to accept a pull request that "bridges" this module and a parser to make it trivial to go back and forth. |
Do One Thing Well™ |
Do The Things You're Named After™ Do One Thing Well™ would apply if this was named Just how |
I agree the name is misleading. |
+1 for converting back to json. I need to compare the outputted xml to inputted json in my unit tests. |
+1 |
I find the name misreading too. You should at least have a notice saying that it only encodes data in the readme |
Yeah this lib should not really be named |
This is not a criticism of your work, its great, but just something I don't understand. I'm so confused as to why when someone develops a
JSON
andXML
converter that they don't create the other conversion. So all the community has aJSON
toXML
parser and aXML
toJOSN
parser that don't work together. Do you know of any interchangeable parsers? Your library onnpm
is justxml
and it should really be the one that does both.The text was updated successfully, but these errors were encountered: