Button redesign #2148
Open
Button redesign #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mil4n0r
requested changes
Feb 5, 2025
| /** | ||
| * Specifies the semantic meaning of the buttons, which determines its color. | ||
| */ | ||
| semantic?: "default" | "error" | "warning" | "success" | "info"; | ||
| semantic?: Semantic; | ||
| /** | ||
| * If true, the component will be disabled. |
There was a problem hiding this comment.
If true, the button will be disabled.*
Comment on lines
53
to
62
| const IconContainer = styled.div<{ | ||
| size: ButtonPropsType["size"]; | ||
| size: Size; | ||
| }>` | ||
| display: flex; | ||
| font-size: ${(props) => (props.size?.height === "small" ? "16" : props.size?.height === "medium" ? "16" : "24")}px; | ||
| font-size: var(${({ size }) => (size?.height === "large" ? "--height-s" : "--height-xxs")}); | ||
| svg { | ||
| height: ${(props) => (props.size?.height === "small" ? "16" : props.size?.height === "medium" ? "16" : "24")}px; | ||
| width: ${(props) => (props.size?.height === "small" ? "16" : props.size?.height === "medium" ? "16" : "24")}px; | ||
| height: var(${({ size }) => (size?.height === "large" ? "--height-s" : "--height-xxs")}); | ||
| width: ${({ size }) => (size?.height === "large" ? "24" : "16")}px; | ||
| } | ||
| `; |
There was a problem hiding this comment.
Not a mistake, but in my redesigns so far I am using
${({ size }) => (size?.height === "large" ? "var(--height-s)" : "var(--height-xxs)")});
over
var(${({ size }) => (size?.height === "large" ? "--height-s" : "--height-xxs")});
It feels more readable for me, but we can talk about it to come up with a common criteria for all the PRs.
Comment on lines
+21
to
+23
| &:focus:enabled { | ||
| outline: var(--border-width-m) var(--border-style-default) var(--border-color-secondary-medium); | ||
| outline-offset: -2px; |
There was a problem hiding this comment.
Maybe instead of doing this workaround to "overlap" the existing border in the button, we should just use border here to overwrite its color?
There was a problem hiding this comment.
Also, you should add $:active here as well, you can see in figma that the outline must be in both focus and active states.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/libdirectory./websiteas needed.Description
Redesign of the button component following the new design kit specifications, already using the new token architecture (CSS variables).
Additional context