Fix frequent feedback view model instantiation

[samsymons]

Task/Issue URL: https://app.asana.com/0/414235014887631/1209301003276843/f
Tech Design URL:
CC:

Description:

This PR updates the feedback form view model to no longer get created any time the view is recreated. Instead, it gets created at the same time as the regular view model and passed in the same way.

Steps to test this PR:

1. Run this branch and start the VPN
2. Check that you do not see frequent subscription cache hits every couple seconds
3. Next, in the VPN UI, tap the Send Feedback button and go through the flow to the point of submitting an issue (in debug mode, pixels won't send, so feel free to submit)
4. Check that the feedback pixel shows up in the logs with the correct data

Definition of Done (Internal Only):

• Does this PR satisfy our Definition of Done?

Copy Testing:

• Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

• Portrait
• Landscape

Device Testing:

• iPhone SE (1st Gen)
• iPhone 8
• iPhone X
• iPhone 14 Pro
• iPad

OS Testing:

• iOS 15
• iOS 16
• iOS 17

Theme Testing:

• Light theme
• Dark theme

---

Internal references:

Software Engineering Expectations
Technical Design Template

[federicocappelli]

Tested as requested, LGTM