Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to version 1.1.0 #54

Merged
merged 4 commits into from
Feb 3, 2024
Merged

Update to version 1.1.0 #54

merged 4 commits into from
Feb 3, 2024

Conversation

wfordh
Copy link
Collaborator

@wfordh wfordh commented Nov 16, 2023

Summary

I wanted to get this out there even though there's still work to be done. I'd like to get a new release out there with some of the updates around typing and documentation, and also so that hopefully the PyPI page for the package points to the correct repo. Not totally sure how that will work, though. We also should switch to pyproject.toml since it's the new standard for Python packages and not setup.py.

I bumped it to 1.1.0 from 1.0.7 since it felt like switching the PyPI connection and formally swapping the ownership with that step felt like a minor bump instead of just a patch. We could also switch to dated versions, ie v2023.11.16.

To Do

  • build locally to make sure the setuptools bit works as expected
  • test locally to make sure the results match with expectations
  • add an email?

Probably not for this version but could add stuff like linting or formatting to the pyproject.toml file in the future.

Resources

@wfordh wfordh requested a review from dtsong November 16, 2023 20:07
@wfordh
Copy link
Collaborator Author

wfordh commented Jan 20, 2024

@dtsong I switched it over to building with Poetry and added the group email. I ran poetry build and it was successful. I was also able to upload to Test PyPI, though I haven't tried to install from there. Overall I'm pretty sure we can go ahead and publish to PyPI and officially have a new version!

@wfordh wfordh marked this pull request as ready for review January 20, 2024 19:56
@wfordh wfordh merged commit 0633391 into master Feb 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants