Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements to point requests to >=2.22.0 #2

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

dtsong
Copy link
Owner

@dtsong dtsong commented Mar 7, 2022

Porting over original PR from other repository to upgrade the requests requirement due to a discovered CVE in the urlib3 library in requests=2.22.0

SwapnikKatkoori/sleeper-api-wrapper#21

@wfordh
Copy link
Collaborator

wfordh commented Mar 10, 2022

@dtsong of course I think this looks good as the creator of the original PR, so I'll give it a LGTM. If it looks good to you, too, then I can "review" and approve it

@dtsong dtsong requested a review from wfordh March 11, 2022 00:05
@dtsong
Copy link
Owner Author

dtsong commented Mar 11, 2022

awesome, thanks @wfordh , feel free to hit the approval button, needed to have you as a collaborator before merging.

Copy link
Collaborator

@wfordh wfordh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtsong dtsong merged commit 26ce204 into master Mar 11, 2022
@dtsong dtsong deleted the update-requests-requirement branch March 11, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants