Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make polar ice plot more configurable #214

Open
21 tasks
bikegeek opened this issue Mar 11, 2022 · 0 comments
Open
21 tasks

Make polar ice plot more configurable #214

bikegeek opened this issue Mar 11, 2022 · 0 comments
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required METplotpy: Plots priority: medium Medium Priority requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing

Comments

@bikegeek
Copy link
Collaborator

bikegeek commented Mar 11, 2022

Describe the Enhancement

The polar ice plot can only be generated if it is invoked in a directory that has the polar_ice.yaml file. Some users will need the flexibility to invoke the polar_plot.py script from a directory that doesn't contain the polar_ice.yaml file. Some users will need to be able to specify the location of a configuration file which they can edit to point to the location of input data.

Replacing this code:

yaml_file_name = "polar_ice.yaml"
try:
config = yaml.load(
open(yaml_file_name), Loader=yaml.FullLoader)

with code that will support any configuration file (i.e. not limited to only a file named polar_ice.yaml) that is defined with the full file path. Currently, the yaml loader is looking for a polar_ice.yaml file that is in the current working directory.

Time Estimate

Estimate the amount of work required here.
~ 1 1/2 days

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) Minna Win
  • Select no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@bikegeek bikegeek added type: enhancement Improve something that it is currently doing alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Mar 11, 2022
@bikegeek bikegeek added this to the Future release milestone Mar 11, 2022
@bikegeek bikegeek self-assigned this Mar 11, 2022
@bikegeek bikegeek added priority: medium Medium Priority requestor: NOAA/EMC NOAA Environmental Modeling Center METplotpy: Plots labels Mar 11, 2022
@bikegeek bikegeek modified the milestones: METplotpy-2.0, METplotpy 2.1.0-beta2 Mar 1, 2023
@JohnHalleyGotway JohnHalleyGotway modified the milestones: METplotpy 2.1.0-beta2, METplotpy-2.1.0 Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required METplotpy: Plots priority: medium Medium Priority requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

No branches or pull requests

2 participants