bytewords: replace match with precomputed perfect has function #224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two giant match statements with 256 arms incur linear lookup cost. To avoid this, we have defined a simple family of hash functions linear in the first and last character of the encoded string (this lines up nicely with the fact that those two characters are identical for the default and minimal encodings). Exhaustive search has then yielded a perfect hash function (with no collisions) that only needs a domain of roughly double the theoretical minimum (which would be 256 elements).
Other families of hash functions might theoretically yield smaller domains, but we don't judge this to be a relevant optimization for now.
This design achieves the following goals:
Constant lookup time at runtime.
no_std
compliance, i.e. noOnceLock
s and noHashMap
s.No
unsafe
code.The recently introduced decoding test [1] suggests performance improvements of 66%.
[1] bbf09e4